Conversation
Re-verifying this design against main turned up two claims about the repo's own state that no longer hold. They fail differently, and the doc now says so. (a) Wrong. Section 3 calls the one-socket exclusion "already-shipped". 920eced is on no mainline branch and has no PR -- `git branch -a --contains 920eced` returns only design/tailnet-agent-mesh, worktree-phase2-node-descriptor-scope and their fork remotes, and `git grep BUZZ_SINGLE_AGENT_CONNECTION main` is empty. Every citation in that section describes branch code, not deployed behaviour. Added as defect 0, since it strictly precedes the other three: until it merges, they are unobservable in production. (b) Stale, and this document caused it. Section 3.1's "no test, script, or manifest sets it" was true when written (90b58d1, 17:20). de2b194 -- "make BUZZ_SINGLE_AGENT_CONNECTION reachable in deployment", one hour later -- wired deployment.yaml:135 from values.yaml:123 citing exactly that gap. The deploy path exists; the flag is merely defaulted off, which is a cheaper problem than "unwired". Stage 1 updated accordingly: flipping it is a values change on a single-replica relay, not new plumbing. Status bumped to v2.1. No design decision changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Michael Feth <michael@jira-flow.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧪 Jev PR-Triage PilotPR #4: docs: correct two section 3 claims in agent-identity-sync — verdict: REVIEW
Block reason (if any): |
🧪 Jev PR-Triage (v3)PR #4: docs: correct two section 3 claims in agent-identity-sync — verdict: REVIEW
🔍 Reviewer focus
Block reason (if any): |
Stacked on
design/tailnet-agent-mesh(base branch:design/tailnet-agent-mesh, on themfethe1/buzzfork). Read only this PR's own diff — one file, docs only.Re-verifying
docs/agent-identity-sync.mdagainstmainturned up two §3 claims about the repo's own state that no longer hold. They fail in different ways, and the doc now distinguishes them rather than lumping both under "wrong".(a) Wrong — the exclusion is not shipped
§3 describes the one-socket rule as "already-shipped". It is on no mainline branch:
No PR exists for it either (
gh pr list --head design/tailnet-agent-mesh --state all→[]).This matters beyond tidiness: every
file:linein §3 describes branch code, not deployed behaviour, and §3's conclusion ("unifying identity onto a flag-off or multi-pod relay is strictly worse than today") is the safety argument the whole design rests on. Added as defect 0, because it strictly precedes the other three — until920ecedmerges, they are unobservable in production.(b) Stale — and this document is why
§3.1 said "a repo-wide grep finds the variable only in
config.rs— no test, script, or manifest sets it."That was true at the minute it was written (
90b58d15, 2026-08-15 17:20). One hour later,de2b1945— "make BUZZ_SINGLE_AGENT_CONNECTION reachable in deployment" (18:23) — wired it, citing exactly that gap:So the chart now wires
deployment.yaml:135fromvalues.yaml:123(singleAgentConnection: false, commented single-pod-only and pointing back at this document), alongside the defaults-off assertion atconfig.rs:1044-1046.The consequence is a real change in cost: the deploy path exists and the flag is merely defaulted off — a much cheaper problem than "unwired". §6 Stage 1 is updated to say so: flipping it is a values change on a single-replica relay, not new plumbing.
I initially wrote this up as "was never true" and had to correct myself after checking commit ordering. A design doc that provokes a fix and then outlives its own observation is working correctly; it just needs the note.
Scope
docs/agent-identity-sync.md. Docs only, no code.v2→v2.1.🤖 Generated with Claude Code