fix(relay): stop asserting the owner p tag we deliberately removed - #43
Conversation
…moved `workflow_send_message_binds_authority_to_authored_mentions` has failed on product/main since the upstream import: the trigger-rendered arm asserts the owner is p-tagged, while the explicit arm 30 lines above asserts the exact opposite. Root cause is a merge of two conflicting intents, not a code bug: - 31e2f5c (ours, 2026-08-18) moved owner attribution off `p` and onto `actor`/`buzz:workflow-owner`, because ACP wakes on any `p` matching an agent pubkey — p-tagging the owner woke them as a second agent on their own workflow's output. - 93237b4 (upstream block#6953, 2026-08-31) still p-tags the owner and added this assertion to lock that in. The implementation is ours and correct; only the imported assertion was stale. Realign it: the owner must NOT be p-tagged on either arm, and assert positively that `actor` and `buzz:workflow-owner` still carry attribution so the wake path is not silently dropped instead. Verified on real PostgreSQL (migrations applied to head): - trunk: panics at 1371 "must preserve the legacy owner p tag" - patched: `6 passed; 0 failed` across workflow_sink::postgres_tests fmt 0 / clippy -D warnings 0 diagnostics.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI verdict: strict improvement over trunkBaseline = trunk push run
#43's failure set is a strict subset of trunk's. Nothing new is red. The relay/e2e cluster is infrastructure, not code — job Same Docker Hub pull denial that hit #42. Merging: this closes the last red PostgreSQL assertion. |
Closes the last red
PostgreSQL Testsassertion onproduct/main.Problem
workflow_send_message_binds_authority_to_authored_mentionsfails on unmodified trunk atworkflow_sink.rs:1371:The same test asserts the opposite 30 lines earlier for the explicit arm (
author must NOT be p-tagged — that wakes them as a second agent).Root cause — conflicting intents merged, not a code bug
31e2f5cfc7(ours)p→actor+buzz:workflow-owner, because ACP wakes on any matchingp93237b4a74(upstream block#6953)Our implementation is the intended one. Only the imported assertion is stale.
Fix
Realign the trigger-rendered arm with the explicit arm: owner must not be p-tagged, and assert positively that
actorandbuzz:workflow-ownerstill carry attribution — so this can't regress into silently dropping the wake path instead.Verification (real PostgreSQL, migrations applied to head, one container)
1371test result: ok. 6 passed; 0 failedacrossworkflow_sink::postgres_testscargo fmt --check0,cargo clippy --all-targets -- -D warnings0 diagnostics