Chore #125: Rename import/happy fixture and regenerate output - #129
Merged
micheledaddetta-databricks merged 1 commit intoApr 29, 2026
Merged
Conversation
PR #126 (E.0) removed the ProcessUcm-level "direct engine is not yet supported" stub, which silently invalidated this fixture: the assertion PR #123 locked in (the stub error message) is no longer reachable. Rename `acceptance/ucm/import/happy/` -> `acceptance/ucm/import/missing_catalog/` and regenerate `output.txt`. The directory name now describes what is actually being asserted: importing a non-existent catalog produces a structured 404 from the workspace API. The old `happy` name was misleading (no happy path exists yet), and `pending_95` (the rename proposed in #125) is also obsolete now that the stub is gone. The new output is identical across both DATABRICKS_BUNDLE_ENGINE matrix variants, so a single output.txt covers both. Closes#125. Co-authored-by: Isaac
Uh oh!
There was an error while loading. Please reload this page.
micheledaddetta-databricks
deleted the
chore/125-rename-import-fixture-and-regen
branch
April 29, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#125
Summary
acceptance/ucm/import/happy/->acceptance/ucm/import/missing_catalog/.output.txtto match post-Feat #103: Thread Backend through ProcessOptions, drop verb-side phase chains #126 behavior (the ProcessUcm-level "direct engine is not yet supported" stub is gone, so both matrix variants now reach the actual import path and emit a structured 404 for the missing catalog).Why
PR #126 (E.0) removed the stub guard whose error message PR #123 had locked into this fixture. As a result the acceptance suite has been failing on
mainsince #126 merged, blocking E.1 (#128) and any future PR's acceptance gate. The directory was also misleadingly named (happy/for an error-path fixture); the rename in #125 was deferred work that's cheaper to fold into this fix-up than to keep two issues open.pending_95(the name #125 originally proposed) no longer fits either since the new failure isn't about the #95 stub - it's a clean 404 from the workspace API.Test plan
GOPROXY=direct GOTOOLCHAIN=local GOSUMDB=off go test ./acceptance -run 'TestAccept/ucm/import' -count=1-> greenGOPROXY=direct GOTOOLCHAIN=local GOSUMDB=off go test ./acceptance -run 'TestAccept/ucm' -count=1-> green (full UCM acceptance suite)DATABRICKS_BUNDLE_ENGINE=terraformandDATABRICKS_BUNDLE_ENGINE=directvariants share the sameoutput.txt.Fork-divergence notes
cmd/ucm/**,ucm/**,.claude/**,.github/workflows/upstream-sync.yml: onlyacceptance/ucm/import/**(rename + regenerated output). This is fork-only test scaffolding, no upstream conflict surface.Base branch
main. Not stacked.Notes for reviewer
The new locked-in behavior is a clean error from inside the import flow (404 from the workspace API surfaced via
direct import: ...), not a panic or opaque crash - so this fixture remains a useful regression guard. When E.1+ lands a real reachable happy path, we can addimport/happy/back as a separate fixture and decide whether to retainmissing_catalog/as a 404-error guard.