Skip to content

U johnrag debugging ai trident deployment scripts#4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdrag3 wants to merge 12 commits into from
Closed

U johnrag debugging ai trident deployment scripts #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0ae00ab
updated path to set_secret.py in deploy_steps.yml
Sep 18, 2019
e0ddbab
updating set_secret.py path
Sep 18, 2019
29ace8e
not using AzureRM this time
Sep 19, 2019
11f1703
adding exception info to the python script
Sep 19, 2019
21033ba
removing try catch
Sep 19, 2019
f2882f6
adding deployment-id to resource group
Sep 19, 2019
592ff63
yaml formatting
Sep 19, 2019
7bc5f43
trying to store secret with powershell instead of python
Sep 19, 2019
44b7284
removed keyvault from powershell
Sep 19, 2019
25403dd
merging from master
Sep 19, 2019
fbd5247
adding path correctio to set_secret.py python script location
Sep 19, 2019
5ae64ed
plubing in deployment id for resource group
Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .ci/scripts/set_secret.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
#!/usr/bin/python3

import argparse
from azure.keyvault import KeyVaultClient
from azure.common.client_factory import get_client_from_cli_profile
Expand All@@ -8,20 +7,14 @@
def set_secret(kv_endpoint, secret_name, secret_value):
client = get_client_from_cli_profile(KeyVaultClient)

try:
client.set_secret(kv_endpoint, secret_name, secret_value)
return "Successfully created secret: {secret_name} in keyvault: {kv_endpoint}".format(
secret_name=secret_name, kv_endpoint=kv_endpoint)
except Exception as ex:
return "Failed to create secret: {secret_name} in keyvault: {kv_endpoint}".format(
secret_name=secret_name, kv_endpoint=kv_endpoint)
client.set_secret(kv_endpoint, secret_name, secret_value)
return "Successfully created secret: {secret_name} in keyvault: {kv_endpoint}".format(secret_name=secret_name, kv_endpoint=kv_endpoint)


def parse_args():
parser = argparse.ArgumentParser()

parser.add_argument('-n', '--secretName', required=True,
help="The name of the secret")
parser.add_argument('-n', '--secretName', required=True, help="The name of the secret")

return parser.parse_args()

Expand Down
4 changes: 3 additions & 1 deletion .ci/steps/createResourceGroupTemplate.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ parameters:
alias : $(Build.RequestedForId)
project : "e2etestharness"
expires : "2019-08-01"
deploymentguidtag: "ABC123"


steps:
- task: AzureCLI@1
Expand All@@ -14,4 +16,4 @@ steps:
scriptLocation: inlineScript
inlineScript: |
echo Execute Resource Group Delete
az group create -l ${{parameters.location}} -n ${{parameters.azureresourcegroup}} --tags alias='${{parameters.alias}}' project='${{parameters.project}}' expires='${{parameters.expires}}'
az group create -l ${{parameters.location}} -n ${{parameters.azureresourcegroup}} --tags deployment-id='${{parameters.deploymentguidtag}}' alias='${{parameters.alias}}' project='${{parameters.project}}' expires='${{parameters.expires}}'
3 changes: 2 additions & 1 deletion .ci/steps/deploy_steps.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ steps:
alias : ${{parameters.alias}}
project : ${{parameters.project}}
expires : ${{parameters.expires}}
deploymentguidtag: ${{parameters.deploymentguidtag}}

- template: ${{parameters.template}}
parameters:
Expand All@@ -53,7 +54,7 @@ steps:
inlineScript: |
source activate ${{parameters.conda}}
pip install azure azure-cli
python .ci/scripts/set_secret.py -n "${{parameters.ENVIRONMENT_PREFIX}}-key"
python AIArchitecturesAndPractices/.ci/scripts/set_secret.py -n "${{parameters.ENVIRONMENT_PREFIX}}-key"


- task: AzurePowerShell@4
Expand Down