Uh oh!
There was an error while loading. Please reload this page.
Clean up the initial matches if some don't pass later conditions. - #423
Merged
Conversation
Cleans up a bunch of tests that were passing around exit codes instead of using asserts directly on them.
Closed
If you try to install a tool that is already installed you get a failure. It appears that the pipelines now include this by default, but I don't know if we can rely on that, so just changing this to update which should work either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#422
When a finding condition is used Application Inspector uses a WithinClause to parse the existing captures and see if any of them are valid given the conditon. This worked fine when there was a single match with a condition. When there are multiple matches if any of them passed the condition they were all being returned because we were extracting the results from the initial match not the within clause and we neglected to remove the matches that did not match the condition. This PR changes the WithinClause to remove any matches which don't pass its condition from the original list of captures which is later processed (if any of them pass the withinclause).
Also bumps some dependencies and refactors some tests.