Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 24, 2026. It is now read-only.
[TL] initial implement flashattention op in TL - #202
Merged
Conversation
Zhengju Tang (tzj-fxz)
commented
Sep 29, 2024
Contributor
- add initial implementation of flashattention in ops/general_flashatten
- wrap implementation in config class and op class
- fix kernel name bug
- modify tilelang test script
- add ops flashattention test script
Lei Wang (LeiWang1999)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contributions. Zhengju Tang (@tzj-fxz)
I've left some comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lei Wang (LeiWang1999)
commented
Sep 30, 2024
Contributor
thanks Zhengju Tang (@tzj-fxz) ，overall lgtm, should fix the test. |
Zhengju Tang (tzj-fxz)
commented
Sep 30, 2024
ContributorAuthor
OK, now CI tests are passed in the newest commit. |
Lei Wang (LeiWang1999)
commented
Sep 30, 2024
Contributor
Merged, thanks Zhengju Tang (@tzj-fxz) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.