Skip to content

Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy Gerlicher (AndyGerlicher) merged 1 commit into from
Aug 14, 2026
Merged

Fix file cloning on .NET 11 #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
<PropertyGroup>

<!-- DOCSYNC: When changing version number update README.md -->
<Version>0.5.0</Version>
<Version>0.5.1</Version>
<AssemblyVersion>0.9.9999.0</AssemblyVersion>

<Company>Microsoft</Company>
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down
4 changes: 2 additions & 2 deletions lib/Windows/NativeMethods.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

[StructLayout(LayoutKind.Sequential)]
public ref struct DUPLICATE_EXTENTS_DATA
public struct DUPLICATE_EXTENTS_DATA
{
public SafeHandle? FileHandle;
public IntPtr FileHandle;
public long SourceFileOffset;
public long TargetFileOffset;
public long ByteCount;
Expand Down
30 changes: 29 additions & 1 deletion lib/Windows/WindowsCopyOnWriteFilesystem.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
}
}

// Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
private void DuplicateExtents(
SafeFileHandle sourceFileHandle,
SafeFileHandle destFileHandle,
long sourceFileLength,
VolumeInfo sourceVolume,
string source,
string destination)
{
bool sourceFileHandleRefAdded = false;
try
{
sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
DuplicateExtentsCore(
sourceFileHandle.DangerousGetHandle(),
destFileHandle,
sourceFileLength,
sourceVolume,
source,
destination);
}
finally
{
if (sourceFileHandleRefAdded)
{
sourceFileHandle.DangerousRelease();
}
}
}

private void DuplicateExtentsCore(
IntPtr sourceFileHandle,
SafeFileHandle destFileHandle,
long sourceFileLength,
VolumeInfo sourceVolume,
string source,
string destination)
{
var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
{
Expand Down
14 changes: 14 additions & 0 deletions tests/unit/Windows/CopyOnWriteTests_Windows.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
[TestMethod]
public void DuplicateExtentsDataMatchesWin32Layout()
{
Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
}

[TestMethod]
[DataRow(false)]
[DataRow(true)]
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix file cloning on .NET 11 by AndyGerlicher · Pull Request #58 · microsoft/CopyOnWrite · GitHub
Skip to content
Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Andy Gerlicher (AndyGerlicher)
merged 1 commit into

from

Aug 14, 2026
 Merged


Fix file cloning on .NET 11
#58
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 <PropertyGroup>

 <!-- DOCSYNC: When changing version number update README.md -->
 <Version>0.5.0</Version>
 <Version>0.5.1</Version>
 <AssemblyVersion>0.9.9999.0</AssemblyVersion>

 <Company>Microsoft</Company>
Expand Down

1 change: 1 addition & 0 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down

4 changes: 2 additions & 2 deletions
lib/Windows/NativeMethods.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
 public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

 [StructLayout(LayoutKind.Sequential)]
 public ref struct DUPLICATE_EXTENTS_DATA
 public struct DUPLICATE_EXTENTS_DATA
 {
 public SafeHandle? FileHandle;
 public IntPtr FileHandle;
 public long SourceFileOffset;
 public long TargetFileOffset;
 public long ByteCount;
Expand Down

30 changes: 29 additions & 1 deletion
lib/Windows/WindowsCopyOnWriteFilesystem.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
 }
 }

 // Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
 private void DuplicateExtents(
 SafeFileHandle sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 bool sourceFileHandleRefAdded = false;
 try
 {
 sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
 DuplicateExtentsCore(
 sourceFileHandle.DangerousGetHandle(),
 destFileHandle,
 sourceFileLength,
 sourceVolume,
 source,
 destination);
 }
 finally
 {
 if (sourceFileHandleRefAdded)
 {
 sourceFileHandle.DangerousRelease();
 }
 }
 }

 private void DuplicateExtentsCore(
 IntPtr sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
 {
Expand Down

14 changes: 14 additions & 0 deletions
tests/unit/Windows/CopyOnWriteTests_Windows.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
 [TestMethod]
 public void DuplicateExtentsDataMatchesWin32Layout()
 {
 Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

 Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
 Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
 Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
 Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
 Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
 Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
 Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
 }

 [TestMethod]
 [DataRow(false)]
 [DataRow(true)]
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix file cloning on .NET 11 by AndyGerlicher · Pull Request #58 · microsoft/CopyOnWrite · GitHub
Skip to content
Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Andy Gerlicher (AndyGerlicher)
merged 1 commit into

from

Aug 14, 2026
 Merged


Fix file cloning on .NET 11
#58
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 <PropertyGroup>

 <!-- DOCSYNC: When changing version number update README.md -->
 <Version>0.5.0</Version>
 <Version>0.5.1</Version>
 <AssemblyVersion>0.9.9999.0</AssemblyVersion>

 <Company>Microsoft</Company>
Expand Down

1 change: 1 addition & 0 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down

4 changes: 2 additions & 2 deletions
lib/Windows/NativeMethods.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
 public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

 [StructLayout(LayoutKind.Sequential)]
 public ref struct DUPLICATE_EXTENTS_DATA
 public struct DUPLICATE_EXTENTS_DATA
 {
 public SafeHandle? FileHandle;
 public IntPtr FileHandle;
 public long SourceFileOffset;
 public long TargetFileOffset;
 public long ByteCount;
Expand Down

30 changes: 29 additions & 1 deletion
lib/Windows/WindowsCopyOnWriteFilesystem.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
 }
 }

 // Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
 private void DuplicateExtents(
 SafeFileHandle sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 bool sourceFileHandleRefAdded = false;
 try
 {
 sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
 DuplicateExtentsCore(
 sourceFileHandle.DangerousGetHandle(),
 destFileHandle,
 sourceFileLength,
 sourceVolume,
 source,
 destination);
 }
 finally
 {
 if (sourceFileHandleRefAdded)
 {
 sourceFileHandle.DangerousRelease();
 }
 }
 }

 private void DuplicateExtentsCore(
 IntPtr sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
 {
Expand Down

14 changes: 14 additions & 0 deletions
tests/unit/Windows/CopyOnWriteTests_Windows.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
 [TestMethod]
 public void DuplicateExtentsDataMatchesWin32Layout()
 {
 Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

 Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
 Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
 Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
 Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
 Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
 Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
 Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
 }

 [TestMethod]
 [DataRow(false)]
 [DataRow(true)]
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix file cloning on .NET 11 by AndyGerlicher · Pull Request #58 · microsoft/CopyOnWrite · GitHub
Skip to content
Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Andy Gerlicher (AndyGerlicher)
merged 1 commit into

from

Aug 14, 2026
 Merged


Fix file cloning on .NET 11
#58
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 <PropertyGroup>

 <!-- DOCSYNC: When changing version number update README.md -->
 <Version>0.5.0</Version>
 <Version>0.5.1</Version>
 <AssemblyVersion>0.9.9999.0</AssemblyVersion>

 <Company>Microsoft</Company>
Expand Down

1 change: 1 addition & 0 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down

4 changes: 2 additions & 2 deletions
lib/Windows/NativeMethods.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
 public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

 [StructLayout(LayoutKind.Sequential)]
 public ref struct DUPLICATE_EXTENTS_DATA
 public struct DUPLICATE_EXTENTS_DATA
 {
 public SafeHandle? FileHandle;
 public IntPtr FileHandle;
 public long SourceFileOffset;
 public long TargetFileOffset;
 public long ByteCount;
Expand Down

30 changes: 29 additions & 1 deletion
lib/Windows/WindowsCopyOnWriteFilesystem.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
 }
 }

 // Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
 private void DuplicateExtents(
 SafeFileHandle sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 bool sourceFileHandleRefAdded = false;
 try
 {
 sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
 DuplicateExtentsCore(
 sourceFileHandle.DangerousGetHandle(),
 destFileHandle,
 sourceFileLength,
 sourceVolume,
 source,
 destination);
 }
 finally
 {
 if (sourceFileHandleRefAdded)
 {
 sourceFileHandle.DangerousRelease();
 }
 }
 }

 private void DuplicateExtentsCore(
 IntPtr sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
 {
Expand Down

14 changes: 14 additions & 0 deletions
tests/unit/Windows/CopyOnWriteTests_Windows.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
 [TestMethod]
 public void DuplicateExtentsDataMatchesWin32Layout()
 {
 Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

 Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
 Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
 Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
 Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
 Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
 Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
 Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
 }

 [TestMethod]
 [DataRow(false)]
 [DataRow(true)]
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix file cloning on .NET 11 by AndyGerlicher · Pull Request #58 · microsoft/CopyOnWrite · GitHub
Skip to content
Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Andy Gerlicher (AndyGerlicher)
merged 1 commit into

from

Aug 14, 2026
 Merged


Fix file cloning on .NET 11
#58
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 <PropertyGroup>

 <!-- DOCSYNC: When changing version number update README.md -->
 <Version>0.5.0</Version>
 <Version>0.5.1</Version>
 <AssemblyVersion>0.9.9999.0</AssemblyVersion>

 <Company>Microsoft</Company>
Expand Down

1 change: 1 addition & 0 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down

4 changes: 2 additions & 2 deletions
lib/Windows/NativeMethods.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
 public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

 [StructLayout(LayoutKind.Sequential)]
 public ref struct DUPLICATE_EXTENTS_DATA
 public struct DUPLICATE_EXTENTS_DATA
 {
 public SafeHandle? FileHandle;
 public IntPtr FileHandle;
 public long SourceFileOffset;
 public long TargetFileOffset;
 public long ByteCount;
Expand Down

30 changes: 29 additions & 1 deletion
lib/Windows/WindowsCopyOnWriteFilesystem.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
 }
 }

 // Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
 private void DuplicateExtents(
 SafeFileHandle sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 bool sourceFileHandleRefAdded = false;
 try
 {
 sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
 DuplicateExtentsCore(
 sourceFileHandle.DangerousGetHandle(),
 destFileHandle,
 sourceFileLength,
 sourceVolume,
 source,
 destination);
 }
 finally
 {
 if (sourceFileHandleRefAdded)
 {
 sourceFileHandle.DangerousRelease();
 }
 }
 }

 private void DuplicateExtentsCore(
 IntPtr sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
 {
Expand Down

14 changes: 14 additions & 0 deletions
tests/unit/Windows/CopyOnWriteTests_Windows.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
 [TestMethod]
 public void DuplicateExtentsDataMatchesWin32Layout()
 {
 Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

 Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
 Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
 Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
 Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
 Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
 Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
 Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
 }

 [TestMethod]
 [DataRow(false)]
 [DataRow(true)]
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix file cloning on .NET 11 by AndyGerlicher · Pull Request #58 · microsoft/CopyOnWrite · GitHub
Skip to content
Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Andy Gerlicher (AndyGerlicher)
merged 1 commit into

from

Aug 14, 2026
 Merged


Fix file cloning on .NET 11
#58
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 <PropertyGroup>

 <!-- DOCSYNC: When changing version number update README.md -->
 <Version>0.5.0</Version>
 <Version>0.5.1</Version>
 <AssemblyVersion>0.9.9999.0</AssemblyVersion>

 <Company>Microsoft</Company>
Expand Down

1 change: 1 addition & 0 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down

4 changes: 2 additions & 2 deletions
lib/Windows/NativeMethods.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
 public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

 [StructLayout(LayoutKind.Sequential)]
 public ref struct DUPLICATE_EXTENTS_DATA
 public struct DUPLICATE_EXTENTS_DATA
 {
 public SafeHandle? FileHandle;
 public IntPtr FileHandle;
 public long SourceFileOffset;
 public long TargetFileOffset;
 public long ByteCount;
Expand Down

30 changes: 29 additions & 1 deletion
lib/Windows/WindowsCopyOnWriteFilesystem.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
 }
 }

 // Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
 private void DuplicateExtents(
 SafeFileHandle sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 bool sourceFileHandleRefAdded = false;
 try
 {
 sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
 DuplicateExtentsCore(
 sourceFileHandle.DangerousGetHandle(),
 destFileHandle,
 sourceFileLength,
 sourceVolume,
 source,
 destination);
 }
 finally
 {
 if (sourceFileHandleRefAdded)
 {
 sourceFileHandle.DangerousRelease();
 }
 }
 }

 private void DuplicateExtentsCore(
 IntPtr sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
 {
Expand Down

14 changes: 14 additions & 0 deletions
tests/unit/Windows/CopyOnWriteTests_Windows.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
 [TestMethod]
 public void DuplicateExtentsDataMatchesWin32Layout()
 {
 Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

 Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
 Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
 Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
 Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
 Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
 Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
 Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
 }

 [TestMethod]
 [DataRow(false)]
 [DataRow(true)]
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Fix file cloning on .NET 11 by AndyGerlicher · Pull Request #58 · microsoft/CopyOnWrite · GitHub
Skip to content
Fix file cloning on .NET 11#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Andy Gerlicher (AndyGerlicher)
merged 1 commit into

from

Aug 14, 2026
 Merged


Fix file cloning on .NET 11
#58
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 <PropertyGroup>

 <!-- DOCSYNC: When changing version number update README.md -->
 <Version>0.5.0</Version>
 <Version>0.5.1</Version>
 <AssemblyVersion>0.9.9999.0</AssemblyVersion>

 <Company>Microsoft</Company>
Expand Down

1 change: 1 addition & 0 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,6 +45,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.5.1 August 2026: Fix file cloning on .NET 11 by using the native `HANDLE` layout for `DUPLICATE_EXTENTS_DATA`.
* 0.5.0 December 2024: Move package framework support from .NET 6 to .NET 8 after 6 reached end-of-life.
* 0.4.2 November 2024: Loosened error handling getting volume information, any volume resulting in an error is ignored. This aids continued failures finding new unique error types based on al lthe various disk subsystems and drivers out there.
* 0.4.1 October 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
Expand Down

4 changes: 2 additions & 2 deletions
lib/Windows/NativeMethods.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -168,9 +168,9 @@ public enum FileSystemFeature : uint
 public static readonly int SizeOfDuplicateExtentsData = Marshal.SizeOf(typeof(DUPLICATE_EXTENTS_DATA));

 [StructLayout(LayoutKind.Sequential)]
 public ref struct DUPLICATE_EXTENTS_DATA
 public struct DUPLICATE_EXTENTS_DATA
 {
 public SafeHandle? FileHandle;
 public IntPtr FileHandle;
 public long SourceFileOffset;
 public long TargetFileOffset;
 public long ByteCount;
Expand Down

30 changes: 29 additions & 1 deletion
lib/Windows/WindowsCopyOnWriteFilesystem.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,14 +246,42 @@ public void CloneFile(string source, string destination, CloneFlags cloneFlags)
 }
 }

 // Separate method to avoid error creating DUPLICATE_EXTENTS_DATA on stack in async method.
 private void DuplicateExtents(
 SafeFileHandle sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 bool sourceFileHandleRefAdded = false;
 try
 {
 sourceFileHandle.DangerousAddRef(ref sourceFileHandleRefAdded);
 DuplicateExtentsCore(
 sourceFileHandle.DangerousGetHandle(),
 destFileHandle,
 sourceFileLength,
 sourceVolume,
 source,
 destination);
 }
 finally
 {
 if (sourceFileHandleRefAdded)
 {
 sourceFileHandle.DangerousRelease();
 }
 }
 }

 private void DuplicateExtentsCore(
 IntPtr sourceFileHandle,
 SafeFileHandle destFileHandle,
 long sourceFileLength,
 VolumeInfo sourceVolume,
 string source,
 string destination)
 {
 var duplicateExtentsData = new NativeMethods.DUPLICATE_EXTENTS_DATA
 {
Expand Down

14 changes: 14 additions & 0 deletions
tests/unit/Windows/CopyOnWriteTests_Windows.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,20 @@ namespace Microsoft.CopyOnWrite.Tests.Windows;
[DoNotParallelize] // Ensure the 32-bit and 64-bit suites do not collide.
public sealed class CopyOnWriteTests_Windows
{
 [TestMethod]
 public void DuplicateExtentsDataMatchesWin32Layout()
 {
 Type duplicateExtentsDataType = typeof(NativeMethods.DUPLICATE_EXTENTS_DATA);

 Assert.IsFalse(duplicateExtentsDataType.IsByRefLike);
 Assert.AreEqual(typeof(IntPtr), duplicateExtentsDataType.GetField(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle))?.FieldType);
 Assert.AreEqual(0, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.FileHandle)).ToInt32());
 Assert.AreEqual(8, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.SourceFileOffset)).ToInt32());
 Assert.AreEqual(16, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.TargetFileOffset)).ToInt32());
 Assert.AreEqual(24, Marshal.OffsetOf<NativeMethods.DUPLICATE_EXTENTS_DATA>(nameof(NativeMethods.DUPLICATE_EXTENTS_DATA.ByteCount)).ToInt32());
 Assert.AreEqual(32, Marshal.SizeOf<NativeMethods.DUPLICATE_EXTENTS_DATA>());
 }

 [TestMethod]
 [DataRow(false)]
 [DataRow(true)]
Expand Down
Loading