Skip to content

Prevent setup from overwriting malformed JSON configuration files - #114

Merged
Oz Zafar (ozzafar) merged 3 commits into
microsoft:mainfrom
fallintoplace:fix/preserve-malformed-config
Aug 24, 2026
Merged

Prevent setup from overwriting malformed JSON configuration files#114
Oz Zafar (ozzafar) merged 3 commits into
microsoft:mainfrom
fallintoplace:fix/preserve-malformed-config

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • stop configuration when an existing JSON file cannot be parsed
  • show an error with an Open Config action
  • preserve the existing file byte-for-byte and skip skill installation
  • document the data-safety behavior

Testing

  • npm run check-types
  • npm run lint
  • npm test (97 passing)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 32ca52f0-95b2-4ab4-8de8-cc870a9df789
@ozzafar

Oz Zafar (ozzafar) commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Thanks for the fix. I updated the branch with current main and added explicit recovery guidance to the error popup: after correcting the malformed JSON, users are directed to run DebugMCP: Show Agent Selection Popup from the Command Palette to retry setup.

The existing malformed file remains byte-for-byte unchanged, setup reports failure instead of overwriting it, and skill installation only proceeds after configuration succeeds.

@ozzafar
Oz Zafar (ozzafar) merged commit bba947b into microsoft:mainAug 24, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fallintoplace@ozzafar