Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Consolate on DevHomeAzureExtension namespace - #230
Merged
Conversation
Kristen Schau (krschau)
requested review from
Branden Bonaby (bbonaby), David Bennett (dkbennett) and Huzaifa Danish (huzaifa-d)June 26, 2024 14:08
Merged
adrastogi
approved these changes
Jun 26, 2024
Vineeth Thomas Alex (vineeththomasalex)
approved these changes
Jun 26, 2024
David Bennett (dkbennett)
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Pulling out part of #229 to just do namespace changes and keep that PR smaller.
As David Bennett (@dkbennett) wrote, "The default when creating a new class is
AzureExtensionnamespace after the directory, but we actually useDevHomeAzureExtensionnamespace name with a shorter directory name to help reduce potential max-path issues. Some components were created using the defaultAzureExtensionnamespace and this was fixed."References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist