Uh oh!
There was an error while loading. Please reload this page.
Zstd_gpu_CI: allow jobs to select an installed adapter - #145
Open
brohan203 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit GPU vendor selection support to the Zstd GPU CI wrapper.
Introduces --gpu-ven-id parsing with validation for malformed, zero, trailing, and overflowing values. Under normal testing, these are retrieved from the CI pipeline. The parsed vendor ID is stored in the test configuration and forwarded to every correctness and performance zstdgpu_demo invocation, ensuring all scenarios use the requested adapter.
Adds focused tests covering parsing, normalization, unset behavior, invalid inputs, and forwarding through both shared argument builders. Existing callers that omit the option retain the demo’s default adapter-selection behavior.