Uh oh!
There was an error while loading. Please reload this page.
Platform toolset143 compatibility - #57
Platform toolset143 compatibility#57Michael Kossin (dimensional-difficulties) wants to merge 7 commits into
Conversation
Michael Kossin (@dimensional-difficulties) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Cooper Partin (coopp)
left a comment
There was a problem hiding this comment.
Looks good to me.
Zu-shi
left a comment
There was a problem hiding this comment.
Submitted some requested changes & comments
| if (GI == 0) | ||
| TileClass[Gid.xy] = float3(TileMaxCoC, TileMinDepth, TileMaxDepth); | ||
| TileClass[Gid.xy] = float3(gs_MaximumCoC[0], gs_FarthestDepthSearch[0], gs_FarthestDepthSearch[0]); |
There was a problem hiding this comment.
(specifically, the first gs_FarthestDepthSearch on this line)
| float3 main( float4 position : SV_Position, float2 uv : TexCoord0 ) : SV_Target0 | ||
| { | ||
| float3 MainColor = ApplyREC2084Curve(ScaleBuffer(uv) / 10000.0); | ||
| float3 MainColor = ApplyREC2084Curve( saturate(ScaleBuffer(uv) / 10000.0) ); |
There was a problem hiding this comment.
I'm not very familiar with this method - what caused the need to add saturate?
There was a problem hiding this comment.
Zu-shi The PR description states that it updates the shaders to match the DirectX-Graphics-Samples repository, which appears to be their primary location and is thus more up-to-date. The saturate call was added in commit 8fc63a4 (Better HDR color range clamp).
| TileMaxDepth = max(TileMaxDepth, gs_FarthestDepthSearch[(GI + i) % 64]); | ||
| TileMaxCoC = max(TileMaxCoC, gs_MaximumCoC[(GI + i) % 64]); | ||
| if (GI < i) | ||
| { |
There was a problem hiding this comment.
Hmm... it would be helpful to have a description in the PR for the reasoning of change in this method. Should this be setting [GI] instead of [i]?
Fixing compatibility issue with Visual C++ version 143. Updating shaders to match those in https://github.com/microsoft/DirectX-Graphics-Samples/tree/master/MiniEngine/Core/Shaders, and updating project files as required.