…722) Fix compilation of `diskann` without the `tracing` feature (see #720): 1. Uniformly using the `tracked_*` macros in `diskann`. 2. Redirecting the `tracked_*` macros to a fancy no-op when the `tracing` feature is disabled. This fancy no-op uses [`format_args!`](https://doc.rust-lang.org/std/macro.format_args.html) to still validate the format of the string and to suppress "unused variable" warnings when the feature is disable. [Compiler explorer](https://godbolt.org/z/f4Ge6P89v) suggests that with optimizations enabled, the construction of [`fmt::Arguments`](https://doc.rust-lang.org/std/fmt/struct.Arguments.html) is removed, meaning this should have no runtime cost in optimized builds. Additionally, `clippy` tests are added for individual crates with features. Feature unification across the workspace results in issues like this not being caught when running CI with the `--workspace` flag. I tried to be selective with these tests to minimize CI overhead. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Uh oh!

[BUG] DiskANN 0.45.0 needs the tracing feature. #720

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[BUG] DiskANN 0.45.0 needs the `tracing` feature. #720