Skip to content

[diskann-wide] Test unaligned loads properly. - #1110

Merged
Mark Hildebrand (hildebrandmw) merged 2 commits into
mainfrom
mhildebr/wide-unaligned
Jun 1, 2026
Merged

[diskann-wide] Test unaligned loads properly.#1110
Mark Hildebrand (hildebrandmw) merged 2 commits into
mainfrom
mhildebr/wide-unaligned

Conversation

@hildebrandmw

Copy link
Copy Markdown
Contributor

Test under-aligned loads and stores in diskann-wide and documents that there are no alignment restrictions on the associated pointer.

This was supposed to be in #981 but somehow didn't make it into the diff.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the diskann-wide portion of unaligned SIMD load/store support by documenting that pointer alignment is unrestricted and strengthening tests to exercise byte-level under-alignment.

Changes:

  • Updates SIMDVector load/store documentation to remove scalar-alignment requirements.
  • Reworks load/store test utilities to validate every byte offset, including predicated access paths.
  • Adds bytemuck test support for safe byte-slice comparisons in test helpers.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
diskann-wide/src/traits.rs Documents no alignment requirements for SIMD load/store pointers.
diskann-wide/src/test_utils/common.rs Adds byte-view helpers for test buffers.
diskann-wide/src/test_utils/load.rs Tests full and predicated loads at byte-level offsets.
diskann-wide/src/test_utils/store.rs Tests full and predicated stores at byte-level offsets.
diskann-wide/Cargo.toml Adds dev dependencies/features needed for byte casting in tests.
Cargo.lock Records the new diskann-wide dev dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread diskann-wide/src/test_utils/store.rs Outdated
Comment thread diskann-wide/src/test_utils/load.rs Outdated
Comment thread diskann-wide/src/test_utils/load.rs Outdated
@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (e2dc9a0) to head (61258d7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
diskann-wide/src/test_utils/store.rs 80.95% 12 Missing ⚠️
diskann-wide/src/test_utils/load.rs 91.66% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   89.46%   89.45%   -0.02%     
==========================================
  Files         482      482              
  Lines       91082    91129      +47     
==========================================
+ Hits        81491    81523      +32     
- Misses       9591     9606      +15     
Flag Coverage Δ
miri 89.45% <86.23%> (-0.02%) ⬇️
unittests 89.10% <86.23%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-wide/src/test_utils/common.rs 79.67% <100.00%> (+1.79%) ⬆️
diskann-wide/src/traits.rs 92.56% <ø> (ø)
diskann-wide/src/test_utils/load.rs 93.33% <91.66%> (-6.67%) ⬇️
diskann-wide/src/test_utils/store.rs 84.61% <80.95%> (-7.84%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw
Mark Hildebrand (hildebrandmw) merged commit 5f63807 into main Jun 1, 2026
25 of 26 checks passed
@hildebrandmw
Mark Hildebrand (hildebrandmw) deleted the mhildebr/wide-unaligned branch June 1, 2026 17:03
weiyaoluo (SeliMeli) pushed a commit to SeliMeli/DiskANN that referenced this pull request Jul 22, 2026
Test under-aligned loads and stores in `diskann-wide` and documents that
there are no alignment restrictions on the associated pointer.

This was supposed to be in microsoft#981 but somehow didn't make it into the
diff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants