Add targeted inline filtering tests - #1144
Merged
Magdalen Dobson Manohar (magdalendobson) merged 3 commits intoJun 11, 2026
Merged
Conversation
added 3 commits
June 10, 2026 12:40
Mark Hildebrand (hildebrandmw)
requested a review
from Magdalen Dobson Manohar (magdalendobson)
June 10, 2026 19:59
Magdalen Dobson Manohar (magdalendobson)
approved these changes
Jun 11, 2026
Magdalen Dobson Manohar (magdalendobson)
merged commit Jun 11, 2026
8d4194b
into
users/magdalen/inline-with-adaptive-l
1 check passed
Magdalen Dobson Manohar (magdalendobson)
deleted the
mhildebr/inline-filtering-tests
branch
June 11, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor integration tests to (1) ensure that the piecewise regime of adaptive-L is properly hit and (2) ensure there is differentiation between the adaptive algorithm and the standard fixed algorithm.
This uses a 1D grid with an exactly seeded filter to ensure the target specificities are hit during the search to the query. By putting additional filter points just outside the window that can be reached with a standard search, we can verify that the various regimes of adaptive-L are properly hit.