Allow inspection of the paged search accessor. - #1364
Merged
Conversation
Mark Hildebrand (hildebrandmw)
requested review from
a team
and
a lite review from Copilot
August 31, 2026 15:29
Copilot started reviewing on behalf of
Mark Hildebrand (hildebrandmw)
August 31, 2026 15:30
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a public accessor method to diskann::graph::search::PagedSearch so callers can inspect (and potentially mutate) the underlying SearchAccessor between page fetches, enabling per-page hooks like metric reporting.
Changes:
- Expose
PagedSearch::accessor(&mut self) -> &mut Ato access the containedSearchAccessor. - Add API documentation explaining the intended use for per-page metric reporting.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
==========================================
+ Coverage 91.55% 92.54% +0.98%
==========================================
Files 521 521
Lines 100371 100374 +3
==========================================
+ Hits 91895 92887 +992
+ Misses 8476 7487 -989
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Harsha Simhadri (harsha-simhadri)
approved these changes
Aug 31, 2026
Jack Moffitt (metajack)
approved these changes
Aug 31, 2026
MustafaIdrisArm
pushed a commit
to MustafaIdrisArm/DiskANN
that referenced
this pull request
Sep 11, 2026
# Breaking Changes Flat search visitors are now query-aware (microsoft#1359) * `flat::FlatIndex` has been removed. The search entry point is now the free function `flat::knn_search`, and the `DistancesUnordered` visitor is constructed per-query rather than reused. The `ElementRef`, `QueryComputer`, and `QueryComputerError` associated types and the visitor GAT have also been removed. `DistancesUnordered` now yields `(id, distance)` pairs directly. Migration: Callers of the old `FlatIndex`/visitor API should: 1. Drop `FlatIndex` and construct your `DistancesUnordered` visitor directly for the query being searched. 2. Replace calls into the removed wrapper with `flat::knn_search(&mut visitor, k, processor, query, &mut output)`. 3. Remove any `ElementRef`/`QueryComputer` implementation, fuse scanning and distance computation directly in your `DistancesUnordered::distances_unordered` implementation. # All Changes * Make `UnalignedSlice` Send and Sync. by @hildebrandmw in microsoft#1348 * Bump actions/checkout from 4.4.0 to 7.0.1 in the github-actions group by @dependabot[bot] in microsoft#1344 * Deduplicate virtual start point edges during disk serialization by @partychen in microsoft#1350 * Fix alpha pruning documentation by @xinyuwen2 in microsoft#1351 * Bump the github-actions group with 4 updates by @dependabot[bot] in microsoft#1356 * Add Neon Inner product u4*u4 kernel by @pfoxARM in microsoft#1353 * Strengthen arguments to `robust_prune`. by @hildebrandmw in microsoft#1358 * Allow inspection of the paged search accessor. by @hildebrandmw in microsoft#1364 * Make flat search visitors query-aware by @partychen in microsoft#1359 * Add Neon inner-product kernel for USlice<2> with spherical wiring by @pfoxARM in microsoft#1363 ## New Contributors * @pfoxARM made their first contribution in microsoft#1353 **Full Changelog**: microsoft/DiskANN@v0.56.0...v0.57.0 Co-authored-by: Mark Hildebrand <mhildebrand@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the
SearchAccessorused duringPagedSearchto be inspected.This allows users of paged search to implement custom pre- and post-page operations including metric reporting.