Uh oh!
There was an error while loading. Please reload this page.
Enforce deterministic review rules in CI - #1370
Draft
Wei Wu (wuw92) wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: da7f008f-1c7b-463a-b3d3-93f6cb12806e
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: da7f008f-1c7b-463a-b3d3-93f6cb12806e
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: da7f008f-1c7b-463a-b3d3-93f6cb12806e
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1370 +/- ##
==========================================
+ Coverage 91.55% 92.53% +0.98%
==========================================
Files 521 521 Lines 100302 100302 ==========================================
+ Hits 91827 92810 +983 + Misses 8475 7492 -983
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #1318 (comment).
What does this implement/fix? Briefly explain your changes.
Move deterministic review feedback into blocking CI so code review can focus on semantic correctness.
too_many_argumentsorsingle_matchsuppressions. The checks are extension-aware, exclude generated and test-input files, compare against the merge base, and preserve existing suppressions across file renames.rustdoc::all, so broken intra-doc links remain merge-blocking without broad allowances.test_datadirectories.The checker tests exercise passing and failing repositories, including shebang/header handling, generated inputs, nested fixtures, missing LFS attributes, structural Clippy allows, renames, and worktree pollution.
Any other comments?
This intentionally limits enforcement to baseline-clean, cross-platform rules. Narrowing conversions, direct panic APIs, duplicate dependency versions, example execution coverage, and broader Miri gating need separate baseline cleanup or a validated allowlist before they can become low-noise merge gates.