Uh oh!
There was an error while loading. Please reload this page.
DiskANN 0.58.0 - #1385
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The PR description references functional PQ/Arc/Shared<'a, T> changes, but the diff only contains version/lockfile updates, so the description (or the included commits) needs to be corrected for consistency.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR appears to be a release/version bump for the DiskANN Rust workspace, updating internal crate versions and lockfile entries to 0.58.0.
Changes:
- Bumped
[workspace.package]version from0.57.0to0.58.0. - Updated all workspace internal dependency versions to
0.58.0. - Refreshed
Cargo.lockto reflect the0.58.0crate versions.
File summaries
| File | Description |
|---|---|
| Cargo.toml | Updates workspace/package and internal workspace dependency versions to 0.58.0. |
| Cargo.lock | Updates locked package entries to 0.58.0 for DiskANN workspace crates. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1385 +/- ##
==========================================
+ Coverage 91.43% 92.54% +1.11%
==========================================
Files 522 522 Lines 100766 100766 ==========================================
+ Hits 92134 93258 +1124 + Misses 8632 7508 -1124
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Breaking Changes since 0.57.0
• Restored support for reference-counted (
Arc) PQ distance tables via a new internalShared<'a, FixedChunkPQTable>enum, unblocking code paths that still depend on owned/shared tables ahead of a full PQ replacement. (#1382)What's Changed
Ownedcomputers. by Mark Hildebrand (@hildebrandmw) in Restore the ability to haveOwnedcomputers. #1382Full Changelog: v0.57.0...v0.58.0