Uh oh!
There was an error while loading. Please reload this page.
Introduce Runtime associated type for Load,Loadable in diskann-record - #1387
Draft
Suhas Jayaram Subramanya (suhasjs) wants to merge 1 commit into
Draft
Introduce Runtime associated type for Load,Loadable in diskann-record#1387Suhas Jayaram Subramanya (suhasjs) wants to merge 1 commit into
Runtime associated type for Load,Loadable in diskann-record#1387Suhas Jayaram Subramanya (suhasjs) wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1387 +/- ##
=======================================
Coverage 91.43% 91.43% =======================================
Files 522 522 Lines 100766 100766 =======================================
Hits 92134 92134 Misses 8632 8632
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (draft) PR addresses the problem of providing some runtime state/config/parameters during index deserialization.
One obvious example of what this enables: an inmem-2.0 index is constructed with
max_slots = 1 millionand contains 900k active points. After serialization to disk, only the data in the active slots is persisted, so using aInMemIndexRuntimeparameter as an arg to theProvider'sLoadimpl withmax_slots = 2 millionto support a larger index size than originally intended.Another obvious use-case involves setting scratch spaces and number of threads, etc.
Reference Issues/PRs
#1386
What does this implement/fix? Briefly explain your changes.
Any other comments?