Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 450
Add agents.md onboarding guide for coding agents#765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
3b4e33cf69b5457d3ca0abf326621be7d71File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| # DiskANN Repository - Agent Onboarding Guide | ||
| **Last Updated**: 2026-02-11 (based on v0.45.0, Rust 1.92) | ||
| This guide helps coding agents understand how to work efficiently with the DiskANN repository. | ||
| --- | ||
| ## Table of Contents | ||
| 1. [Repository Overview](#repository-overview) | ||
| 2. [Repository Structure](#repository-structure) | ||
| 3. [Testing](#testing) | ||
| 4. [Code Quality & Linting](#code-quality--linting) | ||
| --- | ||
| ## Repository Overview | ||
| **DiskANN** is a Rust implementation of scalable approximate nearest neighbor (ANN) search algorithms. The project is a rewrite from C++ to Rust. | ||
| - **Language**: Rust (Edition 2021), toolchain version in [`rust-toolchain.toml`](rust-toolchain.toml) | ||
| - **License**: MIT (see [`LICENSE.txt`](LICENSE.txt)) | ||
| - **Version**: See [`Cargo.toml`](Cargo.toml) | ||
| - **Architecture**: Cargo workspace with 15+ crates | ||
| - **Legacy Code**: Older C++ code is on the `cpp_main` branch (not maintained) | ||
| ### Key Resources | ||
| - **Contributing**: See [`CONTRIBUTING.md`](CONTRIBUTING.md) (requires CLA) | ||
| - **Code of Conduct**: See [`CODE_OF_CONDUCT.md`](CODE_OF_CONDUCT.md) | ||
| --- | ||
| ## Repository Structure | ||
| The repository uses a Cargo workspace with crates organized into functional tiers. See [`Cargo.toml`](Cargo.toml) for: | ||
| - Workspace members and their dependencies | ||
| - Shared dependency versions | ||
| - Build profiles (release, ci) | ||
| - Workspace-level lints | ||
| ### Crate Organization | ||
| **Tier 1: Foundation** | ||
| - `diskann-wide/` - Low-level SIMD, bit manipulation, type width abstractions | ||
| - `diskann-vector/` - Vector primitives and operations | ||
| - `diskann-platform/` - Platform-specific utilities | ||
| **Tier 2: Core Libraries** | ||
| - `diskann-linalg/` - Linear algebra operations | ||
| - `diskann-utils/` - Shared utilities (Reborrow, MatrixView traits) | ||
| - `diskann-quantization/` - Vector quantization (PQ, SQ) | ||
| **Tier 3: Algorithm & Storage** | ||
| - `diskann/` - Core ANN graph algorithm and in-memory indexing (CENTRAL crate) | ||
| - `diskann-providers/` - Storage abstraction layer | ||
| - `diskann-disk/` - Disk-based indexing with io_uring support | ||
| - `diskann-label-filter/` - Inverted index for filtered search | ||
| **Tier 4: Infrastructure & Tools** | ||
| - `diskann-benchmark-runner/` - Test runner infrastructure | ||
| - `diskann-benchmark-core/` - Benchmark framework | ||
| - `diskann-benchmark-simd/` - SIMD-specific benchmarks | ||
| - `diskann-benchmark/` - Benchmark definitions and runners | ||
| - `diskann-tools/` - CLI utilities (autotuner, etc.) | ||
arrayka marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| --- | ||
| ## Testing | ||
| ### Test Execution | ||
| ```bash | ||
| # Run all tests | ||
| cargo test | ||
| # Run tests for specific crate | ||
| cargo test -p diskann | ||
| # Run specific test | ||
| cargo test -p diskann -- --exact test_name | ||
arrayka marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| # Run with CI profile (faster) | ||
| cargo test --profile ci | ||
| # Run doc tests | ||
| cargo test --doc | ||
| ``` | ||
| **Note**: CI uses `cargo-nextest` for running tests. See [`.cargo/nextest.toml`](.cargo/nextest.toml) for test configuration (timeouts, retries, etc.). | ||
| ### Test Baseline Caching System | ||
| DiskANN uses a baseline caching system for regression detection. See [`diskann/README.md`](diskann/README.md) for a high-level overview of how the baseline system works. For implementation and API details, refer directly to: | ||
| - [`diskann/src/test/cache.rs`](diskann/src/test/cache.rs) — core baseline caching APIs | ||
| - [`diskann/src/test/cmp.rs`](diskann/src/test/cmp.rs) — `VerboseEq` and related helpers for better test error messages | ||
| --- | ||
| ## Code Quality & Linting | ||
| ### Formatting | ||
| **Note**: `rustfmt` is not installed by default. Run `rustup component add rustfmt` if needed. | ||
| ```bash | ||
| # Check formatting (matches CI) | ||
| cargo fmt --all --check | ||
| # Apply formatting to all crates | ||
| cargo fmt --all | ||
| ``` | ||
arrayka marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| See [`rustfmt.toml`](rustfmt.toml) for formatting configuration. | ||
| ### Clippy (Linting) | ||
| **Note**: `clippy` is not installed by default. Run `rustup component add clippy` if needed. | ||
| ```bash | ||
| # Basic clippy check | ||
| cargo clippy --workspace --all-targets | ||
| # CI-style check (warnings as errors) | ||
| cargo clippy --workspace --all-targets --config 'build.rustflags=["-Dwarnings"]' | ||
| # Check with no default features (for specific crates) | ||
| cargo clippy -p diskann --no-default-features | ||
| ``` | ||
| See [`clippy.toml`](clippy.toml) for linting rules, including: | ||
| - Disallowed methods (rayon global thread pool, rand::thread_rng, etc.) | ||
| - Required documentation for unsafe blocks | ||
| ### Code Coverage | ||
| Code coverage of changes is required for PRs. See [`.codecov.yml`](.codecov.yml) for coverage policy and thresholds. | ||
| ### CI Pipeline | ||
| CI workflow is defined in [`.github/workflows/ci.yml`](.github/workflows/ci.yml). Key jobs include: | ||
| - Format and clippy checks | ||
| - Tests on multiple platforms (Linux, Windows) | ||
| - Code coverage | ||
| - Architecture compatibility (QEMU) | ||
| ### Test Patterns | ||
| **DON'T**: | ||
arrayka marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| - Add tests for derived traits (Clone, Debug, PartialEq) | ||
| - Add tests for enums unless they have explicit functionality | ||
| --- | ||
| **End of Agent Onboarding Guide** | ||
| *This guide should be updated when major changes occur to the repository structure or development workflows.* | ||
Uh oh!
There was an error while loading. Please reload this page.