Skip to content

Deprecate multi_span, strided_span, etc - #813

Merged
Jordan Maples (JordanMaples) merged 8 commits into
microsoft:masterfrom
JordanMaples:dev/jomaples/deprecate_multispan
Oct 9, 2019
Merged

Deprecate multi_span, strided_span, etc#813
Jordan Maples (JordanMaples) merged 8 commits into
microsoft:masterfrom
JordanMaples:dev/jomaples/deprecate_multispan

Conversation

@JordanMaples

@JordanMaples Jordan Maples (JordanMaples) commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

A number of features exist in the GSL that are not a part of the Core Guidelines.

This PR marks all classes and structs within the multi_span header as deprecated.

@JordanMaples Jordan Maples (JordanMaples) changed the title Deprecating multi_span, strided_span, etc Deprecate multi_span, strided_span, etc Oct 4, 2019
@nitronoid

Copy link
Copy Markdown

This is sad.
The multi-span implementation provided here is the best one I've found and suits all my needs out of the box.
Would you please consider supporting it separately instead of completely abandoning the idea?

@JordanMaples

Copy link
Copy Markdown
Contributor Author

Maintainers' call: Approving this. If you require this, I recommend creating a copy for yourself as we will no longer be maintaining this portion going forward.

@JordanMaples
Jordan Maples (JordanMaples) merged commit 3d56ba9 into microsoft:master Oct 9, 2019
@nitronoid

Copy link
Copy Markdown

To anyone who needs it, I have created a standalone repo for multi_span here: https://github.com/nitronoid/multi_span

Jordan Maples (@JordanMaples) Could you let me know whether I have done the licensing correctly?

@JordanMaples

Copy link
Copy Markdown
Contributor Author

Jack Diver (@nitronoid) It looks correct to me, however I'm not an expert with licensing.
Gabriel Dos Reis (@gdr-at-ms) or Herb Sutter (@hsutter) would either of you mind looking at Jack Diver (@nitronoid)'s licensing on the multi_span mirror (https://github.com/nitronoid/multi_span)?

@JordanMaples
Jordan Maples (JordanMaples) deleted the dev/jomaples/deprecate_multispan branch October 23, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants