Deprecate string_span - #931
Merged
Jordan Maples (JordanMaples) merged 5 commits intoOct 2, 2020
Merged
Jordan Maples (JordanMaples) merged 5 commits into
Jordan Maples (JordanMaples) merged 5 commits into
Conversation
Contributor
Author
|
Travis-CI is clean: https://travis-ci.org/github/microsoft/GSL/builds/732083875 |
Dmitry Kobets (dmitrykobets-msft)
added a commit
that referenced
this pull request
Jun 28, 2023
With `string_span` having been deprecated (#931, #945) and removed (#1074), the header `<gsl/string_span>` now only contains the definitions for the `zstring` family. Update the name accordingly from `<gsl/string_span>` to `<gsl/zstring>`. The old header is now deprecated and should no longer be used and will be removed in some future release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isocpp/CppCoreGuidelines#1680 removed string_span from the C++ Core Guidelines.
This change deprecates
basic_string_span,basic_zstring_span, and all of their derived types.Edit: as with multi_span and strided_span, string_span will remain deprecated in the GSL for a year before it is removed.