Modernize `DotNetSdkLocationHelper` and `hostfxr` interop. by teo-tsirpanis · Pull Request #339 · microsoft/MSBuildLocator

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-21T19:50:25Z

The NativeMethods class was updated to use the P/Invoke source generator, and [UnmanagedCallersOnly]. The changes made are in a similar vein to Use UnmanagedCallersOnly in AssemblyDependencyResolver. dotnet/runtime#119034.
The DotNetSdkLocationHelper class was updated to use APIs added in newer frameworks, like the regex source generator, or APIs to resolve symlinks. The latter also lets us remove the P/Invokes to libc.

YuliiaKovalova · 2025-09-29T10:05:10Z

hi Theodore Tsirpanis (@teo-tsirpanis)
please resolve the conflicts and I will review it

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T11:31:08Z

YuliiaKovalova conflicts resolved.

Rainer Sigwald (rainersigwald)

No, wait, something is wrong:

❯ .\samples\BuilderApp\bin\Debug\net8.0\BuilderApp.exe .\MSBuildLocator.slnSample MSBuild Builder App 1.9.7+e4c2ece661.Process terminated. Assertion failed. at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2_callback(hostfxr_resolve_sdk2_result_key_t key, Void* value) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 63 at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.<hostfxr_resolve_sdk2>g____PInvoke|4_0(Void* __exe_dir_native, Void* __working_dir_native, hostfxr_resolve_sdk2_flags_t __flags_native, __result_native) at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, result) in S:\work\MSBuildLocator\src\MSBuildLocator\obj\Debug\net8.0\Microsoft.Interop.LibraryImportGenerator\Microsoft.Interop.LibraryImportGenerator\LibraryImports.g.cs:line 19 at Microsoft.Build.Locator.NativeMethods.hostfxr_resolve_sdk2(String exe_dir, String working_dir, hostfxr_resolve_sdk2_flags_t flags, String& resolved_sdk_dir, String& global_json_path) in S:\work\MSBuildLocator\src\MSBuildLocator\NativeMethods.cs:line 36 at Microsoft.Build.Locator.DotNetSdkLocationHelper.<GetInstances>g__GetSdkFromGlobalSettings|4_2(String workingDirectory) in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 153 at Microsoft.Build.Locator.DotNetSdkLocationHelper.GetInstances(String workingDirectory, Boolean allowQueryAllRuntimes, Boolean allowAllDotnetLocations)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\DotNetSdkLocationHelper.cs:line 82 at Microsoft.Build.Locator.MSBuildLocator.GetInstances(VisualStudioInstanceQueryOptions options)+MoveNext() in S:\work\MSBuildLocator\src\MSBuildLocator\MSBuildLocator.cs:line 389 at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at BuilderApp.Program.Main(String[] args) in S:\work\MSBuildLocator\samples\BuilderApp\Program.cs:line 26

Rainer Sigwald (rainersigwald) · 2025-09-29T19:46:49Z

It is getting called twice, the first time with resolved_sdk_dir = 1, the second with 3. That appears to be newer than the docs describe

https://github.com/dotnet/runtime/blob/925205d06d82ce5e0d24e4e313fd66887fe89795/src/native/corehost/fxr/hostfxr.cpp#L225-L249

Maybe the assertions should be moved inside the switch Theodore Tsirpanis (@teo-tsirpanis)?

Theodore Tsirpanis (teo-tsirpanis) · 2025-09-29T19:52:29Z

Removed assertions, as per the other native callback.

Rainer Sigwald (rainersigwald)

Fantastic, thank you!

Theodore Tsirpanis (teo-tsirpanis) added 5 commits August 22, 2025 22:57

Use framework API to resolve symlink.
7692e5c

Refactor hostfxr bindings and use the P/Invoke source generator.
92f8957

Use newer APIs in DotNetSdkLocationHelper.
a11e5dd

Use custom marshaller for auto-encoding strings.
b2d6edf

Remove BOM.
0eb3704

Jan Kotas (jkotas) mentioned this pull request Sep 25, 2025
[Mono] System.Runtime.InteropServices.MarshalDirectiveException dotnet/msbuild#12570
Closed

Merge branch 'main' into hostfxr-interop
e4c2ece

YuliiaKovalova approved these changes Sep 29, 2025
View reviewed changes

Rainer Sigwald (rainersigwald) approved these changes Sep 29, 2025
View reviewed changes

Rainer Sigwald (rainersigwald) requested changes Sep 29, 2025
View reviewed changes

Theodore Tsirpanis (teo-tsirpanis) added 2 commits September 29, 2025 22:48

Remove assertions inside native callbacks.
210afd3

Some more cleanups.
c601723

Rainer Sigwald (rainersigwald) approved these changes Sep 29, 2025
View reviewed changes

YuliiaKovalova merged commit 6bbaaa5 into microsoft:mainSep 30, 2025
2 checks passed

Theodore Tsirpanis (teo-tsirpanis) deleted the hostfxr-interop branch September 30, 2025 11:03

dependabotBot mentioned this pull request Oct 13, 2025
Bump ICSharpCode.Decompiler and 17 others okanakyol/CSharpRepl#6
Closed

This was referenced Jun 10, 2026
[deps]: Bump coverlet.collector and 8 others netinlet/Parlance#140
Closed
Bump the dotnet-sidecars group with 3 updates Nimblesite/SharpLsp#98
Closed

This was referenced Jul 2, 2026
Bump Microsoft.Build.Locator and 7 others bigdra50/unilyze#230
Merged
Bump Microsoft.Build.Locator from 1.2.2 to 1.11.2 jackytea/sandbox-world#1
Closed

dependabotBot mentioned this pull request Jul 15, 2026
[release/9.0]: Bump Microsoft.Build.Locator from 1.7.8 to 1.11.2 dotnet/efcore#38636
Closed

dependabotBot mentioned this pull request Aug 12, 2026
Bump BenchmarkDotNet and 9 others leonardochaia/dotnet-affected#173
Closed

This was referenced Aug 19, 2026
Bump BenchmarkDotNet and 10 others leonardochaia/dotnet-affected#185
Closed
Bump Microsoft.Build.Locator from 1.9.1 to 1.11.2 dependabot/dependabot-core#15995
Merged
Bump the dotnet group with 11 updates leonardochaia/dotnet-affected#188
Closed