Uh oh!
There was an error while loading. Please reload this page.
Dev - #652
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new “Simplified Machine Provisioning” hands-on lab and extends the deployment scripts to support configurable blank OS VHD sizing when no parent VHD is provided.
Changes:
- Added
BlankVHDSizeas a VM configuration option and used it when creating blank OS VHDs. - Added a new HandsOnLabs module (05) and linked it from the root README.
- Documented
BlankVHDSizeinLabConfig.ps1and added lab walkthrough documentation.
Reviewed changes
Copilot reviewed 4 out of 24 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Scripts/LabConfig.ps1 | Documents the new BlankVHDSize VM option. |
| Scripts/3_Deploy.ps1 | Uses BlankVHDSize (or a default) when creating blank OS VHDs. |
| README.md | Adds the new lab to the Hands-on-Labs list. |
| HandsOnLabs/05-SimplifiedMachineProvisioning/readme.md | Introduces the new lab guide and steps. |
Comments suppressed due to low confidence (3)
Scripts/3_Deploy.ps1:596
- Same issue as above:
New-VHD -SizeBytesrequires a numeric value; a quotedBlankVHDSizefrom config would fail binding/conversion here as well. Adding a small validation/cast avoids a hard-to-diagnose runtime failure.
if ($VMConfig.BlankVHDSize){
WriteInfo "`t`t Blank OS VHD Size is $($VMConfig.BlankVHDSize)"
New-VHD -Path $vhdpath -SizeBytes $VMConfig.BlankVHDSize
HandsOnLabs/05-SimplifiedMachineProvisioning/readme.md:114
- This portal link uses
(text)[url], which does not render as a link in Markdown; it should be[text](url).
In Azure Portal, navigate to (Azure Arc Machine provisioning)[https://portal.azure.com/#servicemenu/Microsoft_Azure_ArcCenterUX/AzureArcCenterHub/arcProvisioningDevices] and click on Provision
HandsOnLabs/05-SimplifiedMachineProvisioning/readme.md:139
- This portal link uses
(text)[url], which does not render as a link in Markdown; it should be[text](url).
Connect to SMPNode1/SMPNode2 and to Azure Portal (Arc Provisioning)[https://portal.azure.com/#servicemenu/Microsoft_Azure_ArcCenterUX/AzureArcCenterHub/arcProvisioningDevices] to check the status
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+362
to
+364
| #BlankVHDSize | ||
| Example BlankVHDSize="250GB" | ||
| If ParentVHD is not specified, then new blank VHD will be created with this size. Default is 250GB |
Comment on lines
+440
to
+446
| if ($VMConfig.BlankVHDSize){ | ||
| WriteInfo "`t`t Blank OS VHD Size is $($VMConfig.BlankVHDSize)" | ||
| New-VHD -Path $vhdpath -SizeBytes $VMConfig.BlankVHDSize | ||
| }else{ | ||
| WriteInfo "`t`t Blank OS VHD Size is default - 250GB" | ||
| New-VHD -Path $vhdpath -SizeBytes 250GB | ||
| } |
| ```PowerShell | ||
| $LabConfig=@{AllowedVLANs="1-10,711-719" ; DomainAdminName='LabAdmin'; AdminPassword='LS1setup!'; DCEdition='4'; Internet=$true ; AdditionalNetworksConfig=@(); VMs=@()} | ||
| #labconfig for nested virtualization (eith enough RAM to create ARC RB). |
| ### Task01 - collect ownership vouchers | ||
| #### Step01 - connect to SMB Nodes console |
Comment on lines
+106
to
+110
| In Azure Portal, navigate to (Azure Arc Site Manager)[https://portal.azure.com/#servicemenu/Microsoft_Azure_ArcCenterUX/AzureArcCenterHub/sitesOverview] | ||
| If you dont have site yet, you'll need to create one per Subscription and one per ResourceGroup as on picture below. | ||
|  |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new lab