Uh oh!
There was an error while loading. Please reload this page.
Fix duplicate operation ids in overloads that are composable. - #645
Merged
Andrew Omondi (andrueastman) merged 2 commits intoJan 22, 2025
Merged
Conversation
Andrew Omondi (andrueastman)
marked this pull request as ready for review
January 22, 2025 11:22
Andrew Omondi (andrueastman)
enabled auto-merge
January 22, 2025 11:23
Vincent Biret (baywet)
approved these changes
Jan 22, 2025
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix, can you please also reflect the changes in v2?
Andrew Omondi (andrueastman)
commented
Jan 23, 2025
ContributorAuthor
Just to confirm here Vincent Biret (@baywet), the v2 PR didn't end up with the same regression if you compare the diff of the two PRs, Furthermore, the assertions on the head of the main(v2) branch looks correct/consistent with what we expect. |
Vincent Biret (baywet)
commented
Jan 23, 2025
Member
Thank you for double checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #642
Regression introduced due duplicate operation ids. The change doesn't seem like it was replicated in the v2 branch merge at #641. So no need of a second PR.