Skip to content

Add summary and description to OpenApiReference object - #1077

Merged
Maggie Kimani (MaggieKimani1) merged 9 commits into
release/2.0.0from
mk/add-summary-and-description-to-$ref
Nov 16, 2022
Merged

Add summary and description to OpenApiReference object#1077
Maggie Kimani (MaggieKimani1) merged 9 commits into
release/2.0.0from
mk/add-summary-and-description-to-$ref

Conversation

@MaggieKimani1

@MaggieKimani1Maggie Kimani (MaggieKimani1) commented Nov 14, 2022

Copy link
Copy Markdown
Contributor
  • Adds summary and description fields to the Reference object whose values by default SHOULD override those of the referenced component.
  • Adds test to validate this.

@MaggieKimani1Maggie Kimani (MaggieKimani1) mentioned this pull request Nov 14, 2022
Closed
11 tasks
baywet
Vincent Biret (baywet) reviewed Nov 14, 2022
View reviewed changes
Comment threadsrc/Microsoft.OpenApi.Readers/V2/OpenApiV2VersionService.cs Outdated
Comment threadsrc/Microsoft.OpenApi.Readers/V3/OpenApiExampleDeserializer.cs Outdated
Comment threadsrc/Microsoft.OpenApi.Readers/V3/OpenApiV3VersionService.cs Outdated
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiDocument.cs
baywet
Vincent Biret (baywet) requested changes Nov 16, 2022
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, one last suggestion

Comment threadsrc/Microsoft.OpenApi.Readers/V3/OpenApiV3VersionService.cs Outdated
baywet
Vincent Biret (baywet) approved these changes Nov 16, 2022
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking in all the changes!

@MaggieKimani1
Maggie Kimani (MaggieKimani1) merged commit db75eed into release/2.0.0Nov 16, 2022
@MaggieKimani1
Maggie Kimani (MaggieKimani1) deleted the mk/add-summary-and-description-to-$ref branch November 16, 2022 15:02
@MaggieKimani1Maggie Kimani (MaggieKimani1) mentioned this pull request Dec 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet approved these changes
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@peombwaPeter Ombwa (peombwa)Awaiting requested review from peombwa
@zenginMustafa Zengin (zengin)Awaiting requested review from zengin
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaggieKimani1@baywet