Uh oh!
There was an error while loading. Please reload this page.
Add files via upload - #1080
Conversation
added timespan type
isekene
commented
Nov 17, 2022
|
Vincent Biret (baywet)
left a comment
There was a problem hiding this comment.
isekene thanks for the contribution. It seems that the files you added were not uploaded at the right place (under their original directory).
Could you move them to the right directory please?
Darrel (darrelmiller)
commented
Jan 3, 2023
There is no agreed upon format name for timespan https://spec.openapis.org/registry/format/index.html. Without at least a registry entry, we should not add support for new formats |
Vincent Biret (baywet)
commented
Jan 4, 2023
Darrel (@darrelmiller) while this PR still needs some work (files at not at the right location for instance) before it can be merged, Kiota maps string + duration to TimeSpan in dotnet (and equivalent types in other languages). |
Darrel (darrelmiller)
commented
Jan 13, 2023
Vincent Biret (@baywet) We need to decide why and when we are going to use these native types. Currently we use them in the default property of OpenApiSchema, but in the future that is going to be out of our hands as it will be implemented by a JsonSchema library. I don't think we should try an convert examples into native types during parsing. Parsing the example into native types requires knowing the complete schema which may be referenced and may live in other files. I think if users want to translate an OpenApiExample into a native object, then we should have separate code to do that. I don't think we need the full set of primitive types. |
Vincent Biret (baywet)
commented
Jan 13, 2023
Darrel (@darrelmiller) the aspect that this PR tries to parse the examples was lost on me because of the formatting/files being at the wrong place. |
Darrel (darrelmiller)
commented
Jan 13, 2023
Vincent Biret (@baywet) The problem we have is that even today, validation of examples will fail if a schema is a $ref. That's one reason I changed the example validation to be a warning, not an error. Also, we run into issues like this #1106 where we try and represent a JSON number but there is no equivalent type in .NET. |
Vincent Biret (baywet)
commented
Oct 24, 2023
closing due to inactivity from author |
added timespan type