Uh oh!
There was an error while loading. Please reload this page.
Serialize OpenApiDate values properly to short date - #1102
Merged
Conversation
Irvine Sunday (irvinesunday)
requested review from
Darrel (darrelmiller), Peter Ombwa (peombwa) and Mustafa Zengin (zengin)
as code ownersDecember 6, 2022 14:17
Vincent Biret (baywet)
previously approved these changes
Dec 6, 2022
Millicent Achieng (millicentachieng)
previously approved these changes
Dec 6, 2022
Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail
Irvine Sunday (irvinesunday)
dismissed stale reviews from Millicent Achieng (millicentachieng) and Vincent Biret (baywet)
via
December 8, 2022 07:38
df68816Kudos, SonarCloud Quality Gate passed! |
Irvine Sunday (irvinesunday)
enabled auto-merge (squash)
December 8, 2022 07:58
Vincent Biret (baywet)
approved these changes
Dec 8, 2022
AfsalMcQueen (Afsalmc) pushed a commit
to Afsalmc/OpenAPI.NET
that referenced
this pull request
Dec 14, 2022
* Serialize OpenApiDate properly as Date * Change test date value Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail
Maggie Kimani (MaggieKimani1) added a commit
that referenced
this pull request
Jan 5, 2023
This reverts commit 1a7392f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1101
This PR:
OpenApiDatevalues to short date.