Uh oh!
There was an error while loading. Please reload this page.
Add root property jsonSchemaDialect - #1138
Conversation
…sion for serialiazing/deserializing properties only available in v3.1
…ut version-specific properties
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…3.1 without reference and clean up tests
Vincent Biret (baywet)
left a comment
There was a problem hiding this comment.
Thanks for making these updates. The only remaining thing is this comment I had left earlier.
#1138 (comment)
Also, I'm not asking you to change that, but you could have simply passed callback instead of (w, o) => callback(w, o) in a lot of places. Saying that for future references for you :)
Maggie Kimani (MaggieKimani1)
commented
Mar 1, 2023
Yes, I'm working on that too. I have tests failing locally due to writer scope issues when writing start and end objects with all the serialization refactoring I've implemented. I want to fix these as well and the PR will be good to go. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR:
jsonSchemaDialectfield and logic to serialize and deserializeSerializeAsV3()method by adding an optionalOpenApiSpecVersionparameter in order to write out version-specific properties