JsonSchema.NET Integration by MaggieKimani1 · Pull Request #1278 · microsoft/OpenAPI.NET

Maggie Kimani (MaggieKimani1) · 2023-06-19T08:13:50Z

Resolves integration of the JsonSchema.NET library for complete JSON schema support as part of implementing OpenAPI 3.1.
Fixes:

…ma-library

…-json-schema-library

…eserializer and cleaning up code

…t how to perform upcasting from OpenApiSchema to JsonSchema

…hema-library

…/use-json-node-for-parsing"

…al property

…' into mk/integrate-json-schema-library

Darrel (darrelmiller) · 2023-11-13T03:42:22Z

 /// </summary>
 /// <typeparam name="T"></typeparam>
- public class ValidationRule<T> : ValidationRule where T : IOpenApiElement
+ public class ValidationRule<T> : ValidationRule


Ugh. This is because JsonSchema doesn't implement this interface. Hmm, that seems like it is going to cause us problems.

Darrel (darrelmiller)

It's looking good. I just added a few comments that we should address. Specifically those related to dependencies on the YAML libraries.

sonarqubecloud · 2023-11-21T12:47:50Z

SonarCloud Quality Gate failed.

5 Bugs
0 Vulnerabilities
0 Security Hotspots
19 Code Smells

2.1% Coverage
20.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Maggie Kimani (MaggieKimani1) added 25 commits January 30, 2023 12:40

Merge branch 'mk/add-json-schema-dialect' into mk/integrate-json-sche…
bb672c4
…ma-library

Use JsonSchema.NET for full Json schema support
1a44fe8

Merge remote-tracking branch 'origin/release/2.0.0' into mk/integrate…
dd60371
…-json-schema-library

Decouple v3 and v3.1 deserialization logic by adding a separate 3.1 d…
3afe5c7
…eserializer and cleaning up code

Parse 3.1 fragments
043f5d7

Clean up tests
4b8f8aa

Update test
dd62076

Add extensions property to discriminator for 3.1
4fa6efe

Update packages
3d362c3

Add a separate schema31 property to model objects before we figure ou…
ebece81
…t how to perform upcasting from OpenApiSchema to JsonSchema

Assign node values during schema property mapping
b837812

Add test with advanced schema
f2b3721

Clean up tests
accf19c

Merge branch 'mk/use-json-node-for-parsing' into mk/integrate-json-sc…
e93c6ca
…hema-library

Auto stash before merge of "mk/integrate-json-schema-library" and "mk…
4a46c6f
…/use-json-node-for-parsing"

Refactor V31 Deserializer
02001c3

Replace OpenApiSchema with JsonSchema and clean up code
cf65ddb

Adds a JsonSchemaBuilderExtensions class to support draft 4 keywords etc
7ea161c

Clean up and add a JsonNode property in ParseNode
c2b83d8

Project refactor
113e07f

Set format based on the value within the nested schema and clean up code
8f4da17

Clean up tests
66333a9

Adds logic to serialize Json schema output to yaml format
d4c9630

Adds a schema keyword attribute
df06a39

Clean up test
e2b1602

Maggie Kimani (MaggieKimani1) requested review from Vincent Biret (baywet), Darrel (darrelmiller), Irvine Sunday (irvinesunday), Peter Ombwa (peombwa) and Mustafa Zengin (zengin) as code owners June 19, 2023 08:13

Maggie Kimani (MaggieKimani1) added 4 commits October 24, 2023 17:59

Assign to a backing property in copy constructor instead of the virtu…
8389913
…al property

Fix sonarcloud bug
9d228ae

Fix another bug
29173e0

Reduce code smells
8072bad

Darrel (darrelmiller) reviewed Nov 7, 2023
View reviewed changes

Comment threadsrc/Microsoft.OpenApi.Readers/ParseNodes/AnyListFieldMapParameter.cs

Maggie Kimani (MaggieKimani1) added 3 commits November 8, 2023 12:02

Use camel casing for property name
76a41de

Merge remote-tracking branch 'origin/mk/integrate-json-schema-library…
78b65b5
…' into mk/integrate-json-schema-library

Add test
d4eef1b