Uh oh!
There was an error while loading. Please reload this page.
Refactor readers to reduce surface area - #1958
Merged
Merged
Conversation
| try | ||
| { | ||
| jsonNode = LoadJsonNodesFromYamlDocument(input); | ||
| jsonNode = LoadJsonNodesFromYamlDocument(new StreamReader(input)); // Should we leave the stream open? |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
| try | ||
| { | ||
| jsonNode = LoadJsonNodesFromYamlDocument(input); | ||
| jsonNode = LoadJsonNodesFromYamlDocument(new StreamReader(input)); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
| return ParseAsync(input, reader, format, settings).GetAwaiter().GetResult(); | ||
| #pragma warning restore VSTHRD002 // Avoid problematic synchronous waits | ||
| // Copy string into MemoryStream | ||
| var stream = new MemoryStream(Encoding.UTF8.GetBytes(input)); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
| settings ??= new OpenApiReaderSettings(); | ||
| using var reader = new StringReader(input); | ||
| return Load<T>(reader, version, out diagnostic, format, settings); | ||
| var stream = new MemoryStream(Encoding.UTF8.GetBytes(input)); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
| { | ||
| return Load<T>(memoryStream, version, format, out diagnostic, settings); | ||
| } else { | ||
| memoryStream = new MemoryStream(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
| var reader = OpenApiReaderRegistry.GetReader(format); | ||
| var readResult = await reader.ReadAsync(input, settings, cancellationToken); | ||
| if (settings.LoadExternalRefs) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
| private static ReadResult InternalLoad(MemoryStream input, string format, OpenApiReaderSettings settings = null) | ||
| { | ||
| Utils.CheckArgumentNull(format, nameof(format)); | ||
| if (settings.LoadExternalRefs) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.