Release v2-preview-3 - #1987

Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom
vnext
Closed

Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom
vnext

Conversation

@MaggieKimani1

@MaggieKimani1Maggie Kimani (MaggieKimani1) commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI found potential problems Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
Pattern = schema?.Pattern ?? Pattern;
MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null;
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
Reference = schema?.Reference != null ? new(schema?.Reference) : null;
Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1

Maggie Kimani (MaggieKimani1) commented Dec 19, 2024

Copy link
Copy Markdown
ContributorAuthor

On hold awaiting #1975

@sonarqubecloud

sonarqubecloudBot commented Dec 19, 2024

Copy link
Copy Markdown

Quality Gate FailedQuality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@baywet

Vincent Biret (baywet) commented Dec 19, 2024

Copy link
Copy Markdown
Member

Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.

@MaggieKimani1Maggie Kimani (MaggieKimani1) changed the title Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet) mentioned this pull request Dec 20, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng
+1 more reviewer
@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Release v2-preview-3 - #1987
Closed
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Closed
Release v2-preview-3#1987
Maggie Kimani (MaggieKimani1) wants to merge 101 commits into
mainfrom 
vnext
Conversation
@MaggieKimani1
@MaggieKimani1Maggie Kimani (MaggieKimani1)
commented
Dec 13, 2024

Copy link


Copy Markdown

Contributor
 No description provided. 
@baywet
fix: multiple performance fixes for type serialization
bd9622e
feat: adds to identifier mapping to non nullable enum
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging.Abstractions
ba81e37
Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 8.0.2 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.2...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump System.Text.Json from 8.0.5 to 9.0.0 (#1920)
0ab2350
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.5 to 9.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump System.Formats.Asn1 and Microsoft.Windows.Compatibi…
d5b11ea
…lity (#1921)
Bumps [System.Formats.Asn1](https://github.com/dotnet/runtime) and [Microsoft.Windows.Compatibility](https://github.com/dotnet/windowsdesktop). These dependencies needed to be updated together.
Updates `System.Formats.Asn1` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Windows.Compatibility` from 8.0.10 to 9.0.0
- [Release notes](https://github.com/dotnet/windowsdesktop/releases)
- [Commits](dotnet/windowsdesktop@v8.0.10...v9.0.0)
---
updated-dependencies:
- dependency-name: System.Formats.Asn1
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Windows.Compatibility
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@baywet
Merge pull request#1919from microsoft/dependabot/nuget/Microsoft.Ex…
17f36c6
…tensions.Logging.Abstractions-9.0.0
chore(deps): bump Microsoft.Extensions.Logging.Abstractions from 8.0.2 to 9.0.0
@baywet
Merge pull request#1915from microsoft/fix/performance-type-serializ…
5fef51c
…ation
fix: multiple performance fixes for type serialization feat: adds to identifier mapping to non nullable enum
@dependabot
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
d9fccee
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.0 to 28.2.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.0...28.2.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensio…
243d680
…ns.Logging.Abstractions
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) and [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
342e643
Bumps Microsoft.OData.Edm from 8.2.0 to 8.2.1.
---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers
b5ebf59
Bumps [Microsoft.VisualStudio.Threading.Analyzers](https://github.com/microsoft/vs-threading) from 17.11.20 to 17.12.19.
- [Release notes](https://github.com/microsoft/vs-threading/releases)
- [Commits](https://github.com/microsoft/vs-threading/commits)
---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1925from microsoft/dependabot/nuget/Verify.Xunit…
34c97e4
…-28.2.1
chore(deps): bump Verify.Xunit from 28.2.0 to 28.2.1
@baywet
Merge pull request#1928from microsoft/dependabot/nuget/Microsoft.Vi…
3d2681e
…sualStudio.Threading.Analyzers-17.12.19
chore(deps): bump Microsoft.VisualStudio.Threading.Analyzers from 17.11.20 to 17.12.19
@andrueastman
Merge pull request#1926from microsoft/dependabot/nuget/multi-fd6639…
a64718b
…cb55
chore(deps): bump Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions
@baywet
Merge pull request#1927from microsoft/dependabot/nuget/Microsoft.OD…
863faee
…ata.Edm-8.2.1
chore(deps): bump Microsoft.OData.Edm from 8.2.0 to 8.2.1
@baywet
chore: removes newtonsoft dependency all together
3ca0672
@baywet
Merge pull request#1931from microsoft/chore/newtonsoft-removal
a92dfe7
chore: removes newtonsoft dependency all together
@dependabot
chore(deps): bump Microsoft.Extensions.Logging, Microsoft.Extensions.…
36752ad
…Logging.Abstractions, Microsoft.Extensions.Logging.Console and System.Text.Json (#1932)
Bumps [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime), [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime). These dependencies needed to be updated together.
Updates `Microsoft.Extensions.Logging` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Abstractions` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
Updates `Microsoft.Extensions.Logging.Console` from 8.0.1 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.1...v9.0.0)
Updates `System.Text.Json` from 9.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v9.0.0...v9.0.0)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Logging
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Abstractions
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: Microsoft.Extensions.Logging.Console
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: System.Text.Json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
a44e789
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.2.1 to 28.3.1.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.2.1...28.3.1)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Mike Kistler
Fix link to OpenAPI specification
e1eafea
@andrueastman
Merge pull request#1936from microsoft/dependabot/nuget/Verify.Xunit…
83c571a
…-28.3.1
chore(deps): bump Verify.Xunit from 28.2.1 to 28.3.1
@andrueastman
Merge pull request#1938from mikekistler/mdk/fix-spec-link
f243300
Fix link to OpenAPI specification
@MaggieKimani1
Clean up tags serialization logic
0cab0e7
@MaggieKimani1
Add test to validate
5a51460
@dependabot
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
262acd4
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.3.1 to 28.3.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.3.1...28.3.2)
---
updated-dependencies:
- dependency-name: Verify.Xunit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@andrueastman
Merge pull request#1941from microsoft/dependabot/nuget/Verify.Xunit…
0bf5a42
…-28.3.2
chore(deps): bump Verify.Xunit from 28.3.1 to 28.3.2
@MaggieKimani1
Use range for STJ reference and suppress warnings
6615079
@MaggieKimani1
Revert change for hidi
c98ca28
@MaggieKimani1
Add const keyword and serialization logic
b0a0e8e
@MaggieKimani1
Deserialize const keyword
067fbdd
@MaggieKimani1
Add test and update API
70c7d43
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Dec 19, 2024
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Pattern = schema?.Pattern ?? Pattern;
 MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null; 
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
 UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
 Reference = schema?.Reference != null ? new(schema?.Reference) : null;
 Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
 UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL


Virtual call in constructor or destructor


Avoid virtual calls in a constructor or destructor.

@baywet
chore: exposes unused property so consumers can read the information
4f55597
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names with base definition
b00b557
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: aligns parameter names
f9f7766
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a72c5c2
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes conflicting overload
b9ef21d
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: reduces loops
84e83f4
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: extensions collection initialization
4f28b65
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: restores default constructor for ISerializable implementation
778184f
@baywet
chore: makes regex internal
e86df13
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge pull request#1997from microsoft/chore/linting
28b226e
chore/linting
@baywet
Merge pull request#1999from microsoft/chore/master-linting
fbe390b
chore: fixes extraneous master references
@MaggieKimani1
Maggie Kimani (MaggieKimani1)
commented
Dec 19, 2024

Copy link


Copy Markdown

ContributorAuthor
On hold awaiting #1975
@sonarqubecloud
sonarqubecloudBot
commented
Dec 19, 2024

Copy link


Copy Markdown

Quality Gate FailedQuality Gate failed
Failed conditions
D Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
 Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
@baywet
Vincent Biret (baywet)
commented
Dec 19, 2024

Copy link


Copy Markdown

Member
Maggie Kimani (@MaggieKimani1) you'll need to re-open this one from dev to main instead.
@MaggieKimani1Maggie Kimani (MaggieKimani1)
changed the title
Merge latest changesRelease v2-preview-3Dec 20, 2024
@baywetVincent Biret (baywet)
mentioned this pull request
Dec 20, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet left review comments
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastmanAndrew Omondi (andrueastman)andrueastman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@MaggieKimani1@github-advanced-security@baywet@andrueastman