Skip to content

Fix: reference with folder loading - #2133

Merged
Vincent Biret (baywet) merged 3 commits into
microsoft:mainfrom
dldl-cmd:fix_referenceWithFolderLoading
Feb 7, 2025
Merged

Fix: reference with folder loading#2133
Vincent Biret (baywet) merged 3 commits into
microsoft:mainfrom
dldl-cmd:fix_referenceWithFolderLoading

Conversation

@dldl-cmd

@dldl-cmddldl-cmd commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

A reference like ./Directory/File.json#/components/schema/abc was before read as:
refId = abc
externalResource = ./Directory

Which dropped the file name, which will be fixed by this commit

fixes#1674

A reference like ./Directory/File.json#/components/schema/abc was before read as:
refId = abc
externalResource = ./Directory
Which dropped the file name, which will be fixed by this commit

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

Comment threadsrc/Microsoft.OpenApi/Reader/V3/OpenApiV3Deserializer.cs Outdated
Comment threadsrc/Microsoft.OpenApi/Reader/V31/OpenApiV31Deserializer.cs Outdated
… there will be always a result
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet

Copy link
Copy Markdown
Member

Maggie Kimani (@MaggieKimani1) for final review and merge here please

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relative reference in subdirectory OpenApi document fails to load

3 participants

@dldl-cmd@baywet@MaggieKimani1