Skip to content

Fix issue Empty tag causes error generating Kiota client #2283 - #2286

Merged
Vincent Biret (baywet) merged 3 commits into
microsoft:mainfrom
StefanCuypers:ignore-empty-tags
Mar 28, 2025
Merged

Fix issue Empty tag causes error generating Kiota client #2283#2286
Vincent Biret (baywet) merged 3 commits into
microsoft:mainfrom
StefanCuypers:ignore-empty-tags

Conversation

@StefanCuypers

@StefanCuypersStefan Cuypers (StefanCuypers) commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

When parsing the list of tags, removed tags that are empty so we don't fail on them.

@StefanCuypers

Stefan Cuypers (StefanCuypers) commented Mar 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@microsoft-github-policy-service agree

@MaggieKimani1

Maggie Kimani (MaggieKimani1) commented Mar 27, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi Stefan Cuypers (@StefanCuypers), thank you for your contribution!
Do you mind adding another commit that conforms to the Conventional commits standard?
We use the commit messages to trigger releases and update the changelog.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 27, 2025
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs Fixed
Comment threadsrc/Microsoft.OpenApi/Reader/V3/OpenApiOperationDeserializer.cs Fixed
Comment threadsrc/Microsoft.OpenApi/Reader/V31/OpenApiOperationDeserializer.cs Fixed
baywet
Vincent Biret (baywet) requested changes Mar 27, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Here are a couple of recommendations.

Maggie Kimani (@MaggieKimani1) don't worry about the conventional commits just yet, we'll squash merge and amend the commit message as we do so

Comment threadsrc/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs Outdated
Comment threadsrc/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs Outdated
Comment threadsrc/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs Outdated
baywet
Vincent Biret (baywet) approved these changes Mar 28, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywetVincent Biret (baywet) linked an issue Mar 28, 2025 that may be closed by this pull request
Empty tag causes error generating client #2283
Closed
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) March 28, 2025 12:22
@baywet
Vincent Biret (baywet) merged commit 521d636 into microsoft:mainMar 28, 2025
@release-pleaserelease-pleaseBot mentioned this pull request Mar 28, 2025
Merged
@StefanCuypers
Stefan Cuypers (StefanCuypers) deleted the ignore-empty-tags branch March 28, 2025 12:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet approved these changes
@irvinesundayIrvine Sunday (irvinesunday)Awaiting requested review from irvinesunday
@darrelmillerDarrel (darrelmiller)Awaiting requested review from darrelmiller
@gavinbarronGavin Barron (gavinbarron)Awaiting requested review from gavinbarron
@millicentachiengMillicent Achieng (millicentachieng)Awaiting requested review from millicentachieng
@MaggieKimani1Maggie Kimani (MaggieKimani1)Awaiting requested review from MaggieKimani1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Empty tag causes error generating client

4 participants

@StefanCuypers@MaggieKimani1@baywet@github-advanced-security