Uh oh!
There was an error while loading. Please reload this page.
fix: read (Exclusive)Maximum and (Exclusive)Minimum values as strings and write their raw values during serialization - #2309
Merged
Conversation
… and write their raw values
Uh oh!
There was an error while loading. Please reload this page.
|
Vincent Biret (baywet)
approved these changes
Apr 8, 2025
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Maggie Kimani (MaggieKimani1)
commented
Apr 8, 2025
ContributorAuthor
Vincent Biret (@baywet) Does this need a squash merge with a conventional commit? |
Vincent Biret (baywet)
commented
Apr 8, 2025
Member
Maggie Kimani (@MaggieKimani1) I usually base that decision on: do I have conventional commits already? how many commits are in this PR? 5 or above... squash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1967