Skip to content

fix: Validate schema property is not null - #2468

Merged
Vincent Biret (baywet) merged 2 commits into
microsoft:mainfrom
cliedeman:feat/validate-null-property
Aug 20, 2025
Merged

fix: Validate schema property is not null#2468
Vincent Biret (baywet) merged 2 commits into
microsoft:mainfrom
cliedeman:feat/validate-null-property

Conversation

@cliedeman

@cliedemanCiaran Liedeman (cliedeman) commented Aug 18, 2025•
edited by baywet
Loading

Copy link
Copy Markdown
Contributor

Fixesmicrosoft/kiota#6846 throw error is schema property is null

cliedeman
Ciaran Liedeman (cliedeman) commented Aug 19, 2025
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Properties/SRResource.Designer.cs
baywet
Vincent Biret (baywet) previously approved these changes Aug 19, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet

Vincent Biret (baywet) commented Aug 19, 2025

Copy link
Copy Markdown
Member

Ciaran Liedeman (@cliedeman) with the other PR being merged first (#2459 ), the resource file is conflicting.
Can you please merge the changes? (the easiest is probably to accept all incoming changes, and then re-generate the designer file)

github-advanced-security[bot]
github-advanced-securityAI found potential problems Aug 19, 2025
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Validations/Rules/OpenApiSchemaRules.cs Fixed
@cliedeman
Ciaran Liedeman (cliedeman)force-pushed the feat/validate-null-property branch 2 times, most recently from ad500ce to 886afa1CompareAugust 19, 2025 13:44
@cliedeman

Ciaran Liedeman (cliedeman) commented Aug 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks Vincent Biret (@baywet). Updated

@cliedeman
Ciaran Liedeman (cliedeman)force-pushed the feat/validate-null-property branch 3 times, most recently from 2a60c79 to ae892d9CompareAugust 19, 2025 13:50
baywet
Vincent Biret (baywet) previously approved these changes Aug 19, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

auto-merge was automatically disabled August 19, 2025 20:10

Head branch was pushed to by a user without write access

@cliedeman

Ciaran Liedeman (cliedeman) commented Aug 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Fixed tests

baywet
Vincent Biret (baywet) approved these changes Aug 20, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet
Vincent Biret (baywet) enabled auto-merge (squash) August 20, 2025 12:44
@baywet
Vincent Biret (baywet) merged commit 3326022 into microsoft:mainAug 20, 2025
14 of 16 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The following schema causes null exception during generation

3 participants

@cliedeman@baywet@github-advanced-security