Skip to content

fix: circular ref guard (#3033) - #3039

Merged
Vincent Biret (baywet) merged 3 commits into
support/v2from
fix/circular-ref-guard-to-v2
Aug 19, 2026
Merged

fix: circular ref guard (#3033)#3039
Vincent Biret (baywet) merged 3 commits into
support/v2from
fix/circular-ref-guard-to-v2

Conversation

@baywet

@baywetVincent Biret (baywet) commented Aug 19, 2026

Copy link
Copy Markdown
Member

port of #3033 to v2

@gavinbarron@baywet
fix: circular ref guard (#3033)
00db9a5
* fix: harden yaml parsing
* fix tests and nesting behavior on streams with SharpYaml update
* CodeQL fixes
* update benchmarks
* fix: circular ref guard
* update benchmarks
* fix: harden yaml parsing
* fix tests and nesting behavior on streams with SharpYaml update
* CodeQL fixes
* update benchmarks
* fix: circular ref guard
* update benchmarks
* codeql updates
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Vincent Biret (baywet) requested a review from a team as a code ownerAugust 19, 2026 12:53
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) August 19, 2026 12:54
@baywet
chore: removes invalid property test due to bad cherry-pick
d20027c
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@github-code-quality

github-code-qualityBot commented Aug 19, 2026•
edited
Loading

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in commit b0b0084 in the fix/circular-ref-gua... branch is 41%. The coverage in commit 8018d40 in the support/v2 branch is 89%.

Show a code coverage summary of the most impacted files.
Filesupport/v28018d40fix/circular-ref-gua...b0b0084+/-
/home/runner/wo...MapParameter.cs100%0%-100%
/home/runner/wo...Deserializer.cs81%0%-81%
/home/runner/wo...pyReferences.cs63%31%-32%
/home/runner/wo...piJsonReader.cs100%72%-28%
/home/runner/wo...Deserializer.cs90%62%-28%
/home/runner/wo...s/OpenApiTag.cs100%76%-24%
/home/runner/wo...Deserializer.cs100%81%-19%
/home/runner/wo...Deserializer.cs96%81%-15%
/home/runner/wo...Deserializer.cs97%89%-8%
/home/runner/wo...piComponents.cs94%87%-7%

Updated August 19, 2026 14:45 UTC

@sonarqubecloud

sonarqubecloudBot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.2% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

@baywet
Vincent Biret (baywet) merged commit 406e6fd into support/v2Aug 19, 2026
17 checks passed
@baywet
Vincent Biret (baywet) deleted the fix/circular-ref-guard-to-v2 branch August 19, 2026 15:23
@release-please-token-providerrelease-please-token-providerBot mentioned this pull request Aug 19, 2026
Merged
@gavinbarronGavin Barron (gavinbarron) mentioned this pull request Aug 19, 2026
Merged
This was referenced Aug 19, 2026
Open
Open
Open
Open
Open
Open
Closed
Open
Closed
Open
Open
Open
Open
Merged
Open
Merged
Closed
This was referenced Aug 21, 2026
Open
Open
Closed
Merged
Open
Closed
Open
Open
Open
Open
Open
Closed
Open
Open
Merged
Merged
Closed
Open
Closed
Open
Merged
Open
Closed
Open
Closed
Open
Open
Closed
Open
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinbarronGavin Barron (gavinbarron)gavinbarron approved these changes

Assignees

@baywetVincent Biret (baywet)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baywet@gavinbarron