pac modelbuilder with 1.45.3 creates build errors with messages

[markaloop123]

After upgrading to latest version 1.45.3, using the modelbuilder leads to build errors with messages.
To be precise a Set is created in the Response, using this.Parameters, which does not exist.

as in the Screenshot a Set for Reponse Parameters is added, compared to previous PAC version -> which leads to a project which cannot be built.

For now I switched to using the previous version.

Hope this issue can be fixed quickly or a workaround provided.

Many thanks in advance.

[kip-dk]

7 month down the road and still not fixed. Any change that this will ever be fixed.

The workaround is the change "Parameters" to "Results", but that has to be done for each action method generated, and everyting regenerating the model, you ether have to do same fix again, or undo changes on the generated action messages.

would be nice to get a fix for this,

[prohannes]

As there is no fix provided for a long time, we created a powershell pac wrapper as workaround. Just in case you like to use it as well....

//[..]
    $csharps = Get-ChildItem -Path $PSScriptRoot\$genpath -Include *.cs -Depth 5
    foreach ($csharp in $csharps) {
        try {
            [System.IO.File]::OpenRead($csharp.FullName).Close()
            $csharp.FullName
            $content = (Get-Content $csharp.FullName) 
            $content = FixResponseResultSetters -Lines $content
            $content | Set-Content "$($csharp.FullName).tmp"
            Move-item -Path "$($csharp.FullName).tmp" -destination $csharp.FullName -Force
        }
        catch {
            if (Test-Path "$($csharp.FullName).tmp") {
                try {
                    Remove-Item -Path "$($csharp.FullName).tmp" -Force
                }
                catch {
                    //ignore
                }
            }
        }
    }
//[..]

function FixResponseResultSetters {
    param(
        [string[]]$Lines
    )

    $inResponseClass = $false
    $classBraceDepth = 0
    $inSetter = $false
    $setterBraceDepth = 0

    for ($i = 0; $i -lt $Lines.Count; $i++) {
        $line = $Lines[$i]

        if (-not $inResponseClass -and $line -match 'public partial class .+Response : Microsoft\.Xrm\.Sdk\.OrganizationResponse') {
            $inResponseClass = $true
            $classBraceDepth = 0
            $inSetter = $false
            $setterBraceDepth = 0
        }

        if ($inResponseClass -and -not $inSetter -and $line -match '^\s*set\s*$') {
            $inSetter = $true
            $setterBraceDepth = 0
        }

        if ($inResponseClass -and $inSetter -and $line -match 'this\.Parameters\["') {
            $Lines[$i] = $line -replace 'this\.Parameters\[', 'this.Results['
            $line = $Lines[$i]
        }

        if ($inResponseClass) {
            $classBraceDepth += ([regex]::Matches($line, '\{')).Count
            $classBraceDepth -= ([regex]::Matches($line, '\}')).Count

            if ($inSetter) {
                $setterBraceDepth += ([regex]::Matches($line, '\{')).Count
                $setterBraceDepth -= ([regex]::Matches($line, '\}')).Count

                if ($setterBraceDepth -le 0 -and $line -match '^\s*\}$') {
                    $inSetter = $false
                }
            }

            if ($classBraceDepth -le 0 -and $line -match '^\s*\}$') {
                $inResponseClass = $false
            }
        }
    }

    return $Lines
}

[kip-dk]

Thanks for sharing. I actually did the same fix month ago (sorry for not sharing) after being tired of "undo changes" on fixed message proxy. That impl. is also part of the Boruto Dataverse plugin framework:
public static void FixActionMessageResponseSetters(string proxyMessagesPath)
{
if (!Directory.Exists(proxyMessagesPath))
{
Console.WriteLine($"ProxyMessages folder not found: {proxyMessagesPath}");
return;
}

        var files = Directory.GetFiles(proxyMessagesPath, "*.cs", SearchOption.AllDirectories);

        foreach (var file in files)
        {
            var lines = File.ReadAllLines(file);

            var insideResponseClass = false;
            var braceDepth = 0;
            var updated = false;

            for (int i = 0; i < lines.Length; i++)
            {
                var line = lines[i];

                // detect class start
                if (line.Contains("class") &&
                    line.Contains("OrganizationResponse"))
                {
                    insideResponseClass = true;
                    braceDepth = 0;
                    continue;
                }

                if (insideResponseClass)
                {
                    if (line.Contains("{")) braceDepth++;
                    if (line.Contains("}")) braceDepth--;

                    if (line.Contains("this.Parameters["))
                    {
                        lines[i] = line.Replace("this.Parameters[", "this.Results[");
                        updated = true;
                    }

                    if (braceDepth <= 0)
                    {
                        insideResponseClass = false;
                    }
                }
            }

            if (updated)
            {
                File.WriteAllLines(file, lines, Encoding.UTF8);
                Console.WriteLine($"Fixed: {Path.GetFileName(file)}");
            }
        }
    }