Autogenerated messages are incorrectly created and reference non-existent class attribute with PAC v1.47.1

[ramirezaa]

Describe the bug
When autogenerating the classes from Dynamics, the messageNamesFilter: searchquery and searchautocomplete class files are being generated with a wrong setter. They are using a Parameters to set the response but it does not exist. This issue persists in PAC v1.47.1. The error does not exist with PAC version 1.40.4

To Reproduce
Steps to reproduce the behavior:

1. Use pac version 1.47.1
2. Add the following messages to your builderSettings.json file "messageNamesFilter": ["searchautocomplete", "searchquery","sample_*"]
3. Run: pac modelbuilder build -o . -stf .\builderSettings.json
4. See error in autogenerated files: searchautocomplete.cs and searchquery.cs

[System.Runtime.Serialization.DataContractAttribute(Namespace="http://schemas.microsoft.com/xrm/2011/new/")]
[Microsoft.Xrm.Sdk.Client.ResponseProxyAttribute("searchautocomplete")]
public partial class searchautocompleteResponse : Microsoft.Xrm.Sdk.OrganizationResponse
{
	public searchautocompleteResponse()
	{
	}
	
	public string response
	{
		get
		{
			if (this.Results.Contains("response"))
			{
				return ((string)(this.Results["response"]));
			}
			else
			{
				return default(string);
			}
		}
		set
		{
			this.Parameters["response"] = value;//does not exists
		}
	}
}

[System.Runtime.Serialization.DataContractAttribute(Namespace="http://schemas.microsoft.com/xrm/2011/new/")]
[Microsoft.Xrm.Sdk.Client.ResponseProxyAttribute("searchquery")]
public partial class searchqueryResponse : Microsoft.Xrm.Sdk.OrganizationResponse
{
	public searchqueryResponse()
	{
	}
	
	public string response
	{
		get
		{
			if (this.Results.Contains("response"))
			{
				return ((string)(this.Results["response"]));
			}
			else
			{
				return default(string);
			}
		}
		set
		{
			this.Parameters["response"] = value;//does not exist
		}
	}
}

Error Screenshots

Expected behavior
Autogenerated classes should not throw any errors, similar to PAC version 1.40.4 as seen below

Expected Behavior Screenshots

Desktop (please complete the following information):

• OS: Microsoft Windows 10 Business
• Browser: Chrome

[chrispiasecki]

Confirmed I am also experiencing this as well when generating messages for my Custom Apis. Am on the latest PAC CLI (1.48.2).

[Joseph-Duty-VA]

same as #31

[daryllabar]

Curious as to the work around those that are having this issue are doing. ramirezaa / Chris Piasecki (@chrispiasecki) / Joseph Duty (@Joseph-Duty-VA) feel free to share?

[ramirezaa]

Daryl LaBar (@daryllabar) as a temporary fix, I have used an earlier version (PAC 1.40.4) to build without errors. I have also directly changed the response set method to return a default string when I was using the latest PAC version (1.47.1).