Update GitHubRepositories Tests and Refactor Get-GitHubRepository Function

[Simon Heather (X-Guardian)]

Description

This PR updates the Pester tests for the GitHubRepositories module to increase the code coverage. This then exposed a code path in the Get-GithubRepository that could never be taken, so the function was refactored to remove this path and simplify the function logic.

A missing ValidateSet was also added to the Affiliation parameter of the Get-GitHubRepository function and incorrect Comment Based Help descriptions for the Get-GitHubRepositoryCollaborator and Move-GitHubRepositoryOwnership functions were fixed.

Issues Fixed

None

References

N/A

Checklist

• You actually ran the code that you just wrote, especially if you did just "one last quick change".
• Comment-based help added/updated, including examples.
• Static analysis is reporting back clean.
• New/changed code adheres to our coding guidelines.
• Changes to the manifest file follow the manifest guidance.
• Unit tests were added/updated and are all passing. See testing guidelines.
• Relevant usage examples have been added/updated in USAGE.md.
• If desired, ensure your name is added to our Contributors list

[Howard Wolosky (HowardWolosky)]

Thanks for this. Conflicts abound in the tests between this and the work going on for pipelining (which is nearly completed), so I'm going to hold off on this one until early next week if you don't mind....

[Simon Heather (X-Guardian)]

Yep no problem Howard. I'll leave it in Draft state for now.

[Howard Wolosky (HowardWolosky)]

Thanks so much for doing this. Increased code coverage in tests is always good, especially if it catches a dead block of code.

Looks like there are a few minor formatting issues and one bug introduced by this.

Otherwise, there may be some duplicative tests within here (especially around topics, collaborators and contributors) with the advent of the tests added for #242.

[Simon Heather (X-Guardian)]

Can we trigger the CI for this PR?

[Howard Wolosky (HowardWolosky)]

Update looks great -- we just need to resolve the duplicative tests.

[Simon Heather (X-Guardian)]

Howard Wolosky (@HowardWolosky) Can we trigger the CI for this PR?

[Howard Wolosky (HowardWolosky)]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Howard Wolosky (HowardWolosky)]

Now that #205 is in, you have some expected merge conflicts to deal with.

[Howard Wolosky (HowardWolosky)]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).