Skip to content

GitHubRepositories: Add Dependabot Service Functions - #235

Merged
Howard Wolosky (HowardWolosky) merged 6 commits into
microsoft:masterfrom
X-Guardian:GitHubRepositories-Dependabot
Jun 24, 2020
Merged

GitHubRepositories: Add Dependabot Service Functions#235
Howard Wolosky (HowardWolosky) merged 6 commits into
microsoft:masterfrom
X-Guardian:GitHubRepositories-Dependabot

Conversation

@X-Guardian

@X-GuardianSimon Heather (X-Guardian) commented Jun 13, 2020•
edited by HowardWolosky
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the following functions to the GitHubRepositories module to manage the GitHub Dependabot services.

  • Test-GitHubRepositoryVulnerabilityAlert
  • Enable-GitHubRepositoryVulnerabilityAlert
  • Disable-GitHubRepositoryVulnerabilityAlert
  • Enable-GitHubRepositorySecurityFix
  • Disable-GitHubRepositorySecurityFix

There is no Test-GitHubRepositorySecurityFix function is there is currently no API for this.

Issues Fixed

None

References

GitHub Repositories Rest API v3

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-Guardian

Simon Heather (X-Guardian) commented Jun 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Can we trigger the CI for this PR?

@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jun 14, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Jun 14, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian

Simon Heather (X-Guardian) commented Jun 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Can we trigger the CI for this PR?

@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jun 14, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Jun 14, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian
Simon Heather (X-Guardian) marked this pull request as ready for review June 14, 2020 18:37
@HowardWoloskyHoward Wolosky (HowardWolosky) added api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/ enhancement An issue or pull request introducing new functionality to the project. api completeness This is basic API functionality that hasn't been implemented yet. and removed enhancement An issue or pull request introducing new functionality to the project. labels Jun 18, 2020
HowardWolosky
Howard Wolosky (HowardWolosky) suggested changes Jun 19, 2020
View reviewed changes

@HowardWoloskyHoward Wolosky (HowardWolosky) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Some feedback for you to consider. Adding in the missing pipeline support is the primary missing work needed right now.

Thanks again.

Comment threadGitHubRepositories.ps1 Outdated
Comment threadGitHubRepositories.ps1 Outdated
Comment threadGitHubRepositories.ps1
Comment threadGitHubRepositories.ps1
Comment threadGitHubRepositories.ps1
Comment threadGitHubRepositories.ps1 Outdated
Comment threadGitHubRepositories.ps1 Outdated
Comment threadGitHubRepositories.ps1 Outdated
Comment threadGitHubRepositories.ps1 Outdated
Comment threadUSAGE.md Outdated
HowardWolosky
Howard Wolosky (HowardWolosky) suggested changes Jun 20, 2020
View reviewed changes

@HowardWoloskyHoward Wolosky (HowardWolosky) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update. Looks like there are still a few things to resolve here, along with our disagreement on the behavior of failures within the Test-* method.

Comment threadGitHubRepositories.ps1 Outdated
Comment threadGitHubRepositories.ps1 Outdated
Comment threadTests/GitHubRepositories.tests.ps1
Comment threadGitHubRepositories.ps1
Comment threadGitHubRepositories.ps1
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jun 20, 2020

Copy link
Copy Markdown
Contributor

Simon Heather (@X-Guardian) - please be sure to @ mention me once this is ready for the next review (there are so many of your reviews for me to keep track of). Thanks again for all your work. Much appreciated!

@HowardWoloskyHoward Wolosky (HowardWolosky) added the waiting for update Waiting for an update to the PR before the next review label Jun 20, 2020
@X-GuardianSimon Heather (X-Guardian) mentioned this pull request Jun 21, 2020
Merged
@X-Guardian

Simon Heather (X-Guardian) commented Jun 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Howard Wolosky (@HowardWolosky) please trigger the CI for this PR.

@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Jun 24, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWoloskyHoward Wolosky (HowardWolosky) removed the waiting for update Waiting for an update to the PR before the next review label Jun 24, 2020
@HowardWolosky
Howard Wolosky (HowardWolosky) merged commit b70c7d4 into microsoft:masterJun 24, 2020
@X-Guardian
Simon Heather (X-Guardian) deleted the GitHubRepositories-Dependabot branch June 28, 2020 00:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HowardWoloskyHoward Wolosky (HowardWolosky)HowardWolosky approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api completenessThis is basic API functionality that hasn't been implemented yet.api-repositoriesWork to complete the API's defined here: https://developer.github.com/v3/repos/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@X-Guardian@HowardWolosky