Skip to content

Invoke-UpdateCheck fixes - #252

Merged
Howard Wolosky (HowardWolosky) merged 1 commit into
microsoft:masterfrom
HowardWolosky:invokeUpdateCheckFixes
Jun 28, 2020
Merged

Invoke-UpdateCheck fixes#252
Howard Wolosky (HowardWolosky) merged 1 commit into
microsoft:masterfrom
HowardWolosky:invokeUpdateCheckFixes

Conversation

@HowardWolosky

@HowardWoloskyHoward Wolosky (HowardWolosky) commented Jun 28, 2020

Copy link
Copy Markdown
Contributor

Description

  • Fixes a regression introduced by #242 unfortunately when I was reducing the lines in the module that exceeded 100 chars.
    Specifically:

    Write-Log=Message $message-Level Verbose

    (note the =Message instead of the -Message)

  • Updates the web request to suppress the progress bar using $ProgressPreference = 'SilentlyContinue'

  • Adds a -Force switch to force the update check to happen again to make future debugging scenarios easier.

Issues Fixed

Fixes#249
Fixes#250

References

n/a

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

* Fixes a regression that was introduced in microsoft#242. A `Write-Log`
command was accidentally updated to pass in `=Message` instead of
`-Message`.
* Updates the web request to suppress the progress bar using
$ProgressPreference = 'SilentlyContinue'
Fixesmicrosoft#249Fixesmicrosoft#250
@HowardWoloskyHoward Wolosky (HowardWolosky) added the bug This relates to a bug in the existing module. label Jun 28, 2020
@HowardWolosky
Howard Wolosky (HowardWolosky) merged commit d32bd11 into microsoft:masterJun 28, 2020
@HowardWolosky
Howard Wolosky (HowardWolosky) deleted the invokeUpdateCheckFixes branch June 28, 2020 17:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugThis relates to a bug in the existing module.

Projects

None yet

1 participant

@HowardWolosky