Skip to content

New GitHubRepositoryBranchProtectionRule Functions - #255

Merged
Howard Wolosky (HowardWolosky) merged 15 commits into
microsoft:masterfrom
X-Guardian:GitHubRepositoryBranchProtection
Jul 31, 2020
Merged

New GitHubRepositoryBranchProtectionRule Functions#255
Howard Wolosky (HowardWolosky) merged 15 commits into
microsoft:masterfrom
X-Guardian:GitHubRepositoryBranchProtection

Conversation

@X-Guardian

@X-GuardianSimon Heather (X-Guardian) commented Jun 29, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the following GitHub Branch Protection Rule functions to the GitHubBranches module:

  • Get-GitHubRepositoryBranchProtectionRule
  • New-GitHubRepositoryBranchProtectionRule
  • Remove-GitHubRepositoryBranchProtectionRule

The lukeCageAcceptHeader was also added to the GitHubCore module with a value of application/vnd.github.luke-cage-preview+json.

Issues Fixed

None

References

GitHub REST API v3

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-GuardianSimon Heather (X-Guardian) mentioned this pull request Jun 29, 2020
Closed
8 tasks
@HowardWoloskyHoward Wolosky (HowardWolosky) added api completeness This is basic API functionality that hasn't been implemented yet. api-repositories-branches Work to complete the API's defined here: https://developer.github.com/v3/repos/branches/ labels Jun 29, 2020
HowardWolosky
Howard Wolosky (HowardWolosky) suggested changes Jul 2, 2020
View reviewed changes

@HowardWoloskyHoward Wolosky (HowardWolosky) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still have some unresolved thoughts from the previous version of this PR that we can continue here.

Comment threadGitHubBranches.ps1 Outdated
Comment threadGitHubBranches.ps1
Comment threadGitHubCore.ps1 Outdated
Comment threadTests/GitHubBranches.tests.ps1 Outdated
Comment threadTests/GitHubBranches.tests.ps1
Comment threadGitHubBranches.ps1 Outdated
Comment threadGitHubBranches.ps1 Outdated
Comment threadGitHubBranches.ps1
Comment threadGitHubBranches.ps1 Outdated
Comment threadGitHubBranches.ps1
@HowardWoloskyHoward Wolosky (HowardWolosky) added the waiting for update Waiting for an update to the PR before the next review label Jul 2, 2020
@X-Guardian
Simon Heather (X-Guardian) marked this pull request as ready for review July 17, 2020 21:08
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Jul 18, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian

Simon Heather (X-Guardian) commented Jul 19, 2020

Copy link
Copy Markdown
ContributorAuthor

Howard Wolosky (@HowardWolosky), this is ready for the next review.

@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Jul 30, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

HowardWolosky
Howard Wolosky (HowardWolosky) suggested changes Jul 30, 2020
View reviewed changes

@HowardWoloskyHoward Wolosky (HowardWolosky) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this New instead of Set certainly simplified this substantially.
Just a couple small observations and this should be good to merge.
Thanks!

Comment threadGitHubBranches.ps1 Outdated
Comment threadGitHubBranches.ps1
Comment threadTests/GitHubBranches.tests.ps1 Outdated
Comment threadTests/GitHubBranches.tests.ps1 Outdated
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Jul 31, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWoloskyHoward Wolosky (HowardWolosky) removed the waiting for update Waiting for an update to the PR before the next review label Jul 31, 2020
@HowardWolosky
Howard Wolosky (HowardWolosky) merged commit 981b85c into microsoft:masterJul 31, 2020
@X-Guardian
Simon Heather (X-Guardian) deleted the GitHubRepositoryBranchProtection branch April 19, 2023 09:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HowardWoloskyHoward Wolosky (HowardWolosky)HowardWolosky requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api completenessThis is basic API functionality that hasn't been implemented yet.api-repositories-branchesWork to complete the API's defined here: https://developer.github.com/v3/repos/branches/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@X-Guardian@HowardWolosky