Skip to content

Pester v5 - #366

Merged
Howard Wolosky (HowardWolosky) merged 49 commits into
microsoft:masterfrom
tigerfansga:PesterV5
Dec 16, 2022
Merged

Pester v5#366
Howard Wolosky (HowardWolosky) merged 49 commits into
microsoft:masterfrom
tigerfansga:PesterV5

Conversation

@tigerfansga

@tigerfansgaMark (tigerfansga) commented Sep 22, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update pester test for Pester v5 support

Issues Fixed

References

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@tigerfansga
Update GitHubUsers.tests.ps1 for Pester v5
fd6eb6a
@tigerfansga
Update GitHubAnalytics.tests.ps1 for Pester v5
5fe9981
@tigerfansga
Update GitHubAssignees.tests.ps1 for PesterV5
64d9137
@tigerfansga
Update GitHubBranches.tests.ps1 for Pester v5
10f9327
@tigerfansga
Update GitHubContents.tests.ps1 for Pester v5
c308af8
@tigerfansga
Update GitHubCore.tests.ps1 for Pester v5
c221a8c
@tigerfansga
Update GitHubEvents.tests.ps1 for Pester v5
3148d70
@tigerfansga
Update GitHubGistComments.tests.ps1 for Pester v5
e908923
@tigerfansga
Update GitHubGists.tests.ps1 for Pester v5
a24d11a
@tigerfansga
Update GitHubGraphQl.tests.ps1 for Pester v5
1bfcaa5
@tigerfansga
Update GitHubIssueComments.tests.ps1 for Pester v5
232e574
@tigerfansga
Update GitHubIssues.tests.ps1 for Pester v5
72e0c72
@tigerfansga
Update GitHubLabels.tests.ps1 for Pester v5
cc7cfc9
@tigerfansga
Update GitHubMilestones.tests.ps1 for Pester v5
f8b3464
@tigerfansga
Update GitHubOrganizations.tests.ps1 for Pester v5
bfc81d8
@tigerfansga
Update GitHubProjectCards.tests.ps1 for Pester v5
d98f1fa
@tigerfansga
Update GitHubProjectColumns.tests.ps1 for Pester v5
79fae40
@tigerfansga
Update GitHubProjects.tests.ps1 for Pester v5
f038807
@tigerfansga
Update GitHubPullRequests.tests.ps1 for Pester v5
dc7a64b
@tigerfansga
Update GitHubReactions.tests.ps1 for Pester v5
a22277d
@tigerfansga
Remove repository code of conduct tests from GitHubMiscellaneous.test…
295c034
…s.ps1
@tigerfansga
Update GitHubReleases.tests.ps1 to account for pre-releases
20423c3
@tigerfansga
Update GitHubReleases.tests.ps1 for Pester v5
d1006a1
@tigerfansga
Update GitHubRepositories.tests.ps1 for Pester v5
be4cd2c
@tigerfansga
Update GitHubRepositoryForks.tests.ps1 for Pester v5
af82bf8
@tigerfansga
Update GitHubRepositoryTraffic.tests.ps1 for Pester v5
39eccbe
@tigerfansga
Update GitHubTeams.tests.ps1 for Pester v5
72f7502
@tigerfansga
Update file formating
07fdf53
@ghost

Deleted user (ghost) commented Sep 22, 2022•
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@azure-pipelines

azure-pipelinesBot commented Dec 15, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky

Howard Wolosky (HowardWolosky) commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Mark (@tigerfansga) - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree.

Still looking through the test failures to see if there's anything there related to your changes...

@tigerfansga

Mark (tigerfansga) commented Dec 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Mark (@tigerfansga) - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree.

Still looking through the test failures to see if there's anything there related to your changes...

That is strange on the CLA because I had accepted it. I can get that done later today. I'm not sure I'll be able to review any requested changes till after the New Year.

@HowardWolosky
Update GitHubBranches.tests.ps1
2b47b43
Error message has changed. Modifying test to simply capture that a failure occurred (without validating the string itself)
@tigerfansga

Mark (tigerfansga) commented Dec 15, 2022

Copy link
Copy Markdown
ContributorAuthor

@microsoft-github-policy-service agree

@HowardWolosky
Merge branch 'master' into PesterV5
9e34ade
@HowardWolosky
Update GitHubRepositories.tests.ps1
3a24ab4
Removes the specific error message check from the `Throw` validation of some tests since the wording of the exception message keeps changing.
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Dec 16, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky
Merge branch 'master' into PesterV5
e59a380
@HowardWolosky
Update settings.json
619ca51
Update the PowerShell extension in VS Code to take advantage of the fact that the tests are now Pester 5 compatible. This allows each individual block to have a Run/Debug link associated with it.
@HowardWolosky
Apply suggestions from code review
40891ca
@HowardWolosky
Apply suggestions from code review
587ece4
@HowardWolosky
Update GitHubProjects.tests.ps1
f85bfc9
Disabling the tests since they no longer work.
@HowardWolosky
Update GitHubProjectColumns.tests.ps1
2a9e13d
Disabling since classic projects have been deprecated.
@HowardWolosky
Update GitHubProjectCards.tests.ps1
fd964ca
Disabling since classic projects are no longer supported.
@HowardWolosky
Update run-unitTests.yaml
9d0c6bc
HowardWolosky
Howard Wolosky (HowardWolosky) reviewed Dec 16, 2022
View reviewed changes
Comment threadbuild/pipelines/templates/run-unitTests.yaml Outdated
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Dec 16, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky

Howard Wolosky (HowardWolosky) commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelinesBot commented Dec 16, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky
Howard Wolosky (HowardWolosky) merged commit 5e1a4b3 into microsoft:masterDec 16, 2022
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

I cleaned up the remaining work in here and got it merged in. Thanks so much to Mark (@tigerfansga) for taking this work on and moving the project forward. It's HUGE that we can now run individual tests directly within VS Code now that we're on Pester 5.
Thanks so much for the contribution!

@tigerfansga
Mark (tigerfansga) deleted the PesterV5 branch March 7, 2024 18:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HowardWoloskyHoward Wolosky (HowardWolosky)HowardWolosky requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get unit tests working against Pester 5.x

2 participants

@tigerfansga@HowardWolosky