Skip to content

Feature/GitHub codespaces organization - #416

Open
Jason Vercellone (vercellone) wants to merge 97 commits into
microsoft:masterfrom
vercellone:feature/GitHubCodespaces-organization
Open

Feature/GitHub codespaces organization#416
Jason Vercellone (vercellone) wants to merge 97 commits into
microsoft:masterfrom
vercellone:feature/GitHubCodespaces-organization

Conversation

@vercellone

@vercelloneJason Vercellone (vercellone) commented Sep 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add outstanding support for Codespaces organizations and Codespaces machines.

Issues Fixed

References

Codespaces/organizations

Codespaces/machines

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

Vercellone, Jasonand others added 30 commits April 27, 2023 23:23
Vercellone, JasonVercellone, Jason
Get-GitHubCodespace
4efc746
@vercellone
- Start-GitHubCodespace
adcd5eb
- Stop-GitHubCodespace
- Wait-GitHubCodespaceAction
@vercellone
Add vercellone to contributors list
006ad5b
@HowardWolosky
Merge branch 'master' into feature/GitHubCodespaces
00eab38
@vercellone
Format Document
4034912
@vercellone
Reorder parameters
b1b7b73
@vercellone
INPUTS +GitHub.Codespace (round trip)
fbb35f0
@vercellone
Mandatory OrganizationName
7590fbb
@vercellone
ParametersSetName Respository => Elements
df55ba9
@vercellone
dedupe Elements+Uri switch cases
62af896
@vercellone
defaultAcceptHeader
4493b66
@vercellone
$null -ne $result.codespaces
d07918c
@vercellone
Start/Stop a Codespace for...authenticated user
fdc1821
@vercellone
mv requirements to .NOTES
8d29c00
@vercellone
Internal-only helper method
2a53725
@vercellone
2s minimum
845af51
@vercellone
until on new line
8b5e9c1
@vercellone
until state -notmatch 'Queued|ing' comments
9d955a5
@vercellone
foreach on new line
29c7c39
@vercellone
Start-Stop filter not function
4798d57
@vercellone
Merge branch 'master' into feature/GitHubCodespaces
feaeae8
@vercellone
(New and Remove)-GitHubCodespace
f924381
@vercellone
Merge branch 'master' into feature/GitHubCodespaces
cc4bfdc
@vercellone
GitHubCodespaces.tests.ps1
f1417db
@vercellone
Option 2: Add-Member RepositoryUrl
c2d9604
@vercellone
Test Get-GitHubCodespace Uri, Uri FromPipeline
e971983
@vercellone
Tests: (Start|Stop)-GitHubCodespace
926f024
@vercellone
Remove-GitHubCodespace -Force
18cd74b
@vercellone
Tests: Delete-GitHubCodespace for auth user
f3016e3
@vercellone
UserName=Mandatory for Organization parameterset
b36e8c7
@vercellone@HowardWolosky
Detailed manage access control usage
82c35a1
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone@HowardWolosky
PARAMETER UserName detailed help text
4c5b7a4
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone@HowardWolosky
Set-GitHubCodespaceVisibility -User octocat
f8a82f4
not howard
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone@HowardWolosky
CmdletBinding SupportsShouldProcess format
f1fa4f6
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone@HowardWolosky
Explicit groupings
a6d81a3
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone
Delete-GitHubCodespaceUser Alias
a411ec8
@vercellone
At this time there is no get visibility
837c1a3
@vercellone
(Add|Remove)-GitHubCodespaceUser perf optimization
f441410
@vercellone
SentenceCase Visibility
69f6a02
@vercellone
.INPUTS GitHub.User
cba3aa4
@vercellone
machines | Add-GitHubCodespaceAdditionalProperties
4d1f9ab
@vercellone
better examples
402beb0
@vercellone
pipeline validation for SelectedMembers
0838682
@vercellone

Jason Vercellone (vercellone) commented Mar 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Please review, Howard Wolosky (@HowardWolosky).

@vercellone

Jason Vercellone (vercellone) commented Mar 18, 2024

Copy link
Copy Markdown
ContributorAuthor

TypeName assertions resolved. Any other feedback, Howard Wolosky (@HowardWolosky)?

HowardWolosky
Howard Wolosky (HowardWolosky) suggested changes Mar 27, 2024
View reviewed changes

@HowardWoloskyHoward Wolosky (HowardWolosky) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates. Looks just about there. I'll kick off a validation run to see if I missed anything else.

Comment threadGitHubCodespaces.ps1
Comment threadGitHubCodespaces.ps1
GitHub Apps must have write access to the codespaces_lifecycle_admin repository permission to use this endpoint.
#>
[CmdletBinding(
DefaultParameterSetName = 'AuthenticatedUser',

@HowardWoloskyHoward Wolosky (HowardWolosky)Mar 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference here would be to avoid ambiguous code. As a code reader, it took too much time for me to look at what's here and parse out what might be happening. A comment could probably address that, but even better would simply be having the code be declarative on intention. In this specific scenario, this could be resolved by augmenting the $CodespaceName declaration to be part of two different parametersets, and then having the default one be one that's actually defined.

 [Parameter(
Mandatory,ValueFromPipeline,ValueFromPipelineByPropertyName,ParameterSetName='Organization')]
[Parameter(
Mandatory,ValueFromPipeline,ValueFromPipelineByPropertyName,ParameterSetName='AuthenticatedUser')]
[string] $CodespaceName,

Comment threadGitHubCodespaces.ps1 Outdated
Comment threadGitHubCodespaces.ps1 Outdated
Comment threadGitHubCodespaces.ps1 Outdated
Comment threadGitHubCodespaces.ps1 Outdated
Comment threadGitHubCodespaces.ps1 Outdated
Comment threadGitHubCodespaces.ps1
Comment threadGitHubCodespaces.ps1 Outdated
Comment threadGitHubCodespaces.ps1 Outdated
@HowardWolosky

Howard Wolosky (HowardWolosky) commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@vercellone@HowardWolosky
nits
740001f
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone@HowardWolosky
Set-GitHubCodespaceVisibility
0df6ced
$null = Invoke-GHRestMethod @params
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone
Made CodespaceName an optional param of the AuthenticatedUser paramet…
7e253ab
…erset for readability
@vercellone

Jason Vercellone (vercellone) commented Apr 16, 2024

Copy link
Copy Markdown
ContributorAuthor

Please review again, Howard Wolosky (@HowardWolosky).

@vercellone

Jason Vercellone (vercellone) commented May 13, 2024

Copy link
Copy Markdown
ContributorAuthor

Howard Wolosky (@HowardWolosky) 8 months!? Your resource management policy seems a bit biased.

@vercellone

Jason Vercellone (vercellone) commented Jul 25, 2024

Copy link
Copy Markdown
ContributorAuthor

Howard Wolosky (@HowardWolosky)?

@vercellone

Jason Vercellone (vercellone) commented Jan 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Am I missing something here? How can I move this PR forward? Should I submit a new PR?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HowardWoloskyHoward Wolosky (HowardWolosky)Awaiting requested review from HowardWolosky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vercellone@HowardWolosky