[Build] Fix building on Visual Studio 17.8 - #29303
Merged
Jaime Bernardo (jaimecbernardo) merged 9 commits intoOct 19, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Jaime Bernardo (jaimecbernardo)
marked this pull request as ready for review
October 19, 2023 10:23
Jaime Bernardo (jaimecbernardo)
requested a review
from Andrey Nekrasov (yuyoyuppe)
October 19, 2023 10:23
Contributor
Author
|
Jeremy Sinclair (@snickler) , FYI. Just in case you need some for the .NET 8 PR :) |
Andrey Nekrasov (yuyoyuppe)
approved these changes
Oct 19, 2023
Andrey Nekrasov (yuyoyuppe)
left a comment
Contributor
There was a problem hiding this comment.
Looks good 🙂
Collaborator
Perfect! |
Jaime Bernardo (jaimecbernardo)
deleted the
dev/jaime/fix-vs17.8-build
branch
October 24, 2023 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Tried building PowerToys
PR Checklist
Detailed Description of the Pull Request / Additional comments
_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNINGas a Preprocessor definition. This is needed because MSVC STL deprecatedstdext::checked_array_iteratoron<iterator>: Modernize and deprecate(un)checked_array_iteratorSTL#3818 and spdlog uses it on https://github.com/gabime/spdlog/blob/ff205fd29a4a2f6ebcbecffd149153256d89a671/include/spdlog/fmt/bundled/format.h#L489-L490Validation Steps Performed
Build local installer using the Visual Studio 17.8.0 Preview 4.0.
Checking if CI still passes on current versions.