Skip to content

Improve InstrumentRef parameter - #7922

Draft
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
microsoft:mainfrom
jenshnielsen:instrument_ref_param_cleanup
Draft

Improve InstrumentRef parameter#7922
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
microsoft:mainfrom
jenshnielsen:instrument_ref_param_cleanup

Conversation

@jenshnielsen

Copy link
Copy Markdown
Collaborator

Support looking up any Insturment as long as the name is know not just the same as the bound instrument

@codecov

codecovBot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.32%. Comparing base (86273d9) to head (9488fc3).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #7922 +/- ##
==========================================
- Coverage 70.30% 69.32% -0.98% 
==========================================
Files 333 333 Lines 32401 32401 ==========================================
- Hits 22778 22462 -316 - Misses 9623 9939 +316 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenshnielsen

Copy link
Copy Markdown
CollaboratorAuthor

This requires changing root_instruments type to be Instrument | None rather than InstrumentBase which is correct and should be done anyway

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jenshnielsen