CMakeLists.txt: semi-documented switch /d2Zi+ used for apparently no reason

[AlexGuteniev]

According to the documentation /d2Zi+ has documented /Zo equivalent and is also implied with /Z7

[BillyONeal]

It is used because when I wrote the CMake build system I made sure it used the same flags as the internal system, which hails from before there was a more public version of /d2Zi+.

[BillyONeal]

(That is to say, there was no consideration between /d2Zi+ and anything else, just a blind copy)

[AlexGuteniev]

This probably means that you still can fix it as long as you change the internal system as well.

Possibly in the past when /Zo did not exist, /d2Zi+ was not implied, so it did make sense, and now it does not.

[StephanTLavavej]

I looked at our internal, legacy, MSBuild build system - this option is ultra-global (used for all of the "vctools" toolset, not just the STL or the libraries), so I see no reason to attempt to change it there.

Therefore, this should be a very simple change - all we need to do is remove /d2Zi+ here:

STL/CMakeLists.txt

Line 71 in 3cca473

add_compile_options(/diagnostics:caret /W4 /WX /w14265 /w15038 /d1FastFail /guard:cf /Z7 /d2Zi+ /Gm- /Gy /Zp8 /std:c++latest /permissive- /Zc:threadSafeInit- /Zl)

[BillyONeal]

I recommend against introducing divergence between the internal and the external system wherever possible until the internal system is decomissioned, or it will be difficult to verify that the new system produces identical results as the old system.

[StephanTLavavej]

Billy O'Neal (@BillyONeal) That's a reasonable concern for large-scale changes but this is one option; I am sure that we'll remember why it is varying.