Skip to content

parallelize tool may hang or crash #1619

Description

@gix

Describe the bug
Adding batching of input files to the parallelize tool for my own needs (cuts the runtime for clang-format in half for me), I believe I encountered two issues:

  1. Quite often it would crash upon returning from p.wait_all() since a kernel mode operation corrupted the stack. This goes away when using an explicit manual-reset event for OVERLAPPED in output_collecting_pipe.
  2. It can hang on exit because the output_collecting_pipe destructor does not clear the running flag. The threadpool callback then starts another IO operation which never completes.

If useful, I can prepare a patch to fix these.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixedSomething works now, yay!infrastructureRelated to repository automation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions