Skip to content

Comment with Short Explanation of Date Conversions (_Civil_from_days, _Days_from_civil) #1641

Description

In #1634, statementreply has implemented clever date conversion algorithms with obvious benchmarks improvements. These calculations have aptly-named variables, but still involve some values that are obscure to the uninformed reader. It would be nice to include some brief comments throughout the algorithm to provide some context around the individual calculations performed.

NOTE:
The previously-implemented algorithms appeared similarly involved, but the functions were commented with the date algorithms paper that introduced them, which contained explanations for the calculations.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationRelated to documentation or commentsfixedSomething works now, yay!

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions