Consider adding a test with `/analyze:plugin EspXEngine.dll`

[AlexGuteniev]

There's already /analyze option:

STL/azure-devops/cmake-configure-build.yml

Line 41 in cc515bb

-DCMAKE_CXX_FLAGS=/analyze:autolog- ^

/analyze:plugin EspXEngine.dll could be added to add C++ Core Guidelines check.
See more: Use the C++ Core Guidelines checkers

As an example #2069 changes can be enforced: https://godbolt.org/z/jfx9dzb1T

It may produce too many warnings that won't b addressed though. These can be suppressed either by ordinary suppression or by [[gsl::suppress(...)]] attribute.

[CaseyCarter]

My gut reaction is that the resulting signal-to-noise ratio would be extremely low and that this wouldn't be worthwhile. That said, I wouldn't mind someone doing the investigation to determine if there's a reasonable compromise subset of the Core Guidelines checkers that we could enable without spamming suppression fluff everywhere. (I suspect that, e.g., "Use span instead of pointer arithmetic" would need to be suppressed globally.)

[AlexGuteniev]

Possibly it can be done like this:

#pragma warning(disable: ALL_CPPCORECHECK_WARNINGS)
#pragma warning(default: 26433 26435 ...)

[StephanTLavavej]

We talked about this in our weekly maintainer meeting - we think that adding an "include all headers" test, covering specific CppCoreCheck warnings (as you mentioned immediately above), could be useful. As I mentioned in Discord, the STL's build is less useful to provide such coverage as it compiles only a fraction of the STL (primarily iostreams/filesystem/multithreading).

We definitely don't want to adopt all C++ Core Guidelines for this codebase, so we'll need to select exactly which warnings to enable. Starting with the "avoid redundant virtual when we have override" convention seems great.